Fix romclass comparison and J9Class lookup given a romclass #19833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What testing has already been run? |
pshipton
reviewed
Jul 9, 2024
I have run |
|
jenkins test sanity,extended,sanity.openjdk,sanity.system,extended.system amac jdk11 |
|
https://openj9-jenkins.osuosl.org/job/Test_openjdk11_j9_sanity.openjdk_aarch64_mac_Personal_testList_0/23/ |
hangshao0
force-pushed
the
FixSCC
branch
2 times, most recently
from
cee711c
to
6472d14
Compare
|
Internal JDK11 sanity.openjdk personal build on aarch64_mac passed with the current change. This can be reviewed again. |
pshipton
reviewed
Jul 10, 2024
1. The romclass comparsion should include the ROM_CLASS_MODIFIERS. 2. For a ROMClass from SCC, its rom memory segment always belongs to the bootstrap class loader. But the class might not be actually loaded by the bootstrap loader. Search all live class loaders to find its defining class loader and the corresponding J9Class. Fixes eclipse-openj9#19781 Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
|
jenkins test sanity,extended,sanity.openjdk,sanity.system,extended.system amac jdk11 |
pshipton
approved these changes
Jul 10, 2024
hangshao0
added a commit
to hangshao0/openj9
that referenced
this pull request
Jul 11, 2024
related to eclipse-openj9#19833 Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19781