Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement JVM_IsContainerized and fix JVM_IsUseContainerSupport #19827

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Implement JVM_IsContainerized and fix JVM_IsUseContainerSupport #19827

merged 1 commit into from
Jul 9, 2024

Conversation

babsingh
Copy link
Contributor

@babsingh babsingh commented Jul 8, 2024 •
edited
Loading

An implementation of JVM_IsContainerized has been added.

The signature of JVM_IsUseContainerSupport has been corrected.

Closes: #19801

@babsingh babsingh requested a review from keithc-ca July 8, 2024 18:38
@babsingh babsingh force-pushed the main10 branch 2 times, most recently from fe56122 to f6a7783 Compare July 8, 2024 20:47
@babsingh babsingh changed the title [JDK24] Implement JVM_IsContainerized Implement JVM_IsContainerized and fix JVM_IsUseContainerSupport Jul 8, 2024
@keithc-ca
Copy link
Contributor

Jenkins compile amac jdk11,jdknext

@babsingh
Copy link
Contributor Author

babsingh commented Jul 8, 2024 •
edited
Loading

Local compilation was failing. Had to move JVM_IsUseContainerSupport into javanextvmi.cpp since BFUjavaVM isn't defined in java11vmi.c.

@babsingh
Copy link
Contributor Author

babsingh commented Jul 8, 2024 •
edited
Loading

Aborted the old PR build: https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/5776

Launching a new one:

Jenkins compile amac jdk11,jdknext

@keithc-ca
Copy link
Contributor

That will not work because javanextvmi.cpp is not included in Java 8 builds, but JVM_IsUseContainerSupport() is required in Java 8.

@babsingh
Copy link
Contributor Author

babsingh commented Jul 8, 2024

That will not work because javanextvmi.cpp is not included in Java 8 builds, but JVM_IsUseContainerSupport() is required in Java 8.

Added BFUjavaVM in java11vmi.c.

Jenkins compile amac jdk11,jdknext

@babsingh
Copy link
Contributor Author

babsingh commented Jul 8, 2024

Jenkins compile zlinux jdk8

@babsingh
Copy link
Contributor Author

babsingh commented Jul 8, 2024

Jenkins compile zlinux jdk8

@babsingh
Copy link
Contributor Author

babsingh commented Jul 8, 2024

Jenkins compile amac jdk11,jdknext

keithc-ca
keithc-ca reviewed Jul 9, 2024
View reviewed changes
runtime/j9vm/java11vmi.c Outdated Show resolved Hide resolved
@babsingh
Implement JVM_IsContainerized and fix JVM_IsUseContainerSupport
c902ff1 
An implementation of JVM_IsContainerized has been added.

The signature of JVM_IsUseContainerSupport has been corrected.

Closes: eclipse-openj9#19801

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh
Copy link
Contributor Author

babsingh commented Jul 9, 2024 •
edited
Loading

Only the function description has been updated. Old PR builds are still good:

@keithc-ca keithc-ca merged commit 99e1f3b into eclipse-openj9:master Jul 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithc-ca keithc-ca keithc-ca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jdk24 JVM_IsContainerized needs to be added
2 participants
@babsingh @keithc-ca