Add override specifier to virtual declarations #19797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various virtual methods in derived classes override their base counterparts but are missing an override specifier. Clang warns about this, and so fails to compile with -Werror. Signed-off-by: Christian Despres <despresc@ibm.com>
|
Attn @mpirvu. |
mpirvu
added
comp:jit
comp:jitserver
|
jenkins compile all jdk17 |
|
jenkins test sanity xlinuxjit,zlinuxjit,alinux64jit jdk17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various virtual methods in derived classes override their base counterparts but are missing an override specifier. Clang warns about this, and so fails to compile with -Werror.