-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIPS disable JCL_TEST_Java-Security tests #19010
FIPS disable JCL_TEST_Java-Security tests #19010
Conversation
Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@llxia this disabled the test completely in the IBM Java 8 builds. Do you have a suggestion to resolve that? |
The other question is, how many other tests have been similarly disabled? |
This should only be disabled when TEST_FLAG=FIPS140_2. See |
Do you mean vmfarm build? |
Yes I mean the vmfarm build. |
I prefer the second way. For the first one, I am not sure what additional issues it may introduce.
This will only affect tests that run for IBM java 8 and are disabled via
openj9/test/functional/JIT_Test/playlist.xml Line 580 in 2095c8e
openj9/test/functional/cmdLineTests/shareClassTests/SCHelperCompatTests/playlist.xml Line 27 in 2095c8e
openj9/test/functional/Java8andUp/playlist.xml Line 1573 in 2095c8e
|
Could we try a build with a TKG update to see what issues there are? In the long term it will be easier if TKG supports the flags rather than having to deal with this for every existing and future test exclusion. IBM Java 8 will continue to 2030 and perhaps beyond. IBM Java 8 isn't exactly the same as OpenJ9 8, there is different code, different defaults, the JIT may behave differently due to these things. It's hard to tell what testing matters and what doesn't. |
An internal issue (backlog/issues/1367) is created. |
FIPS
disableJCL_TEST_Java-Security
testsrelated #16900
Signed-off-by: Jason Feng fengj@ca.ibm.com