Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic-free JNI work #1869

Merged
merged 1 commit into from
May 8, 2018
Merged

Atomic-free JNI work #1869

merged 1 commit into from
May 8, 2018

Conversation

gacholio
Copy link
Contributor

@gacholio gacholio commented May 8, 2018

  • Fix RAS dump code to prioritize inNative over VM access in the
    atomic-free VM.

  • The JIT sampler is depending on VM access to determine the state of a
    thread. Wrap this check in a "not in native" check first in the
    atomic-free VM.

Signed-off-by: Graham Chapman graham_chapman@ca.ibm.com

Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

So the order is always:

  • check inNative first
  • check for vm access after

- Fix RAS dump code to prioritize inNative over VM access in the
atomic-free VM.

- The JIT sampler is depending on VM access to determine the state of a
thread.  Wrap this check in a "not in native" check first in the
atomic-free VM.

Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
@DanHeidinga
Copy link
Member

Jenkins test sanity xlinux jdk8

@eclipse-openj9 eclipse-openj9 deleted a comment from DanHeidinga May 8, 2018
@DanHeidinga DanHeidinga merged commit 0503ef2 into eclipse-openj9:master May 8, 2018
@pshipton pshipton mentioned this pull request Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants