Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valhalla: test updates for lw5 #18558

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

theresa-m
Copy link
Contributor

@theresa-m theresa-m commented Dec 4, 2023

This draft is to track vm changes that are needed for OpenJ9 vm to support ValueTypes in the OpenJDK lw5 branch and will be needed once those changes have been merged to the main branch.

  • Enable lw5 tests and disable qtype tests. Some of these changes won't be needed such as using reflection to call com.ibm.jvm.Dump.SystemDump in ValueTypeTests.checkObject and !stackslots hack in ddr tests.
  • Allow ValueType creation with new//putfield

This is related to #18157

Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@theresa-m theresa-m changed the title Valhalla: vm updates for lw5 Valhalla: test updates for lw5 Oct 1, 2024
@theresa-m
Copy link
Contributor Author

I'm creating a new issue for this work #20268. Initially this draft was to track both vm and test updates that are needed when null-restricted types had support in the extensions repository. We are now in a state where the vm has support and q types are mostly removed but javac does not. While there is a NullRestricted vm annotation supported and the ValueClass api for creating null-restricted arrays its not yet possible so src_lw5 tests can't be used yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:vm project:valhalla Used to track Project Valhalla related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant