Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the new VirtualThread states #18421

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

babsingh
Copy link
Contributor

@babsingh babsingh commented Nov 8, 2023

Related: #18183

New states added:

  • TIMED_PARKING = 7
  • TIMED_PARKED = 8
  • TIMED_PINNED = 9

Old states removed:

  • RUNNABLE_SUSPENDED = (RUNNABLE | SUSPENDED)
  • PARKED_SUSPENDED = (PARKED | SUSPENDED)

Old states modified:

  • YIELDING = 7 -> 10

Related: eclipse-openj9#18183

New states added:
- TIMED_PARKING = 7
- TIMED_PARKED = 8
- TIMED_PINNED = 9

Old states removed:
- RUNNABLE_SUSPENDED = (RUNNABLE | SUSPENDED)
- PARKED_SUSPENDED = (PARKED | SUSPENDED)

Old states modified:
- YIELDING = 7 -> 10

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh
Copy link
Contributor Author

babsingh commented Nov 8, 2023

This PR depends on ibmruntimes/openj9-openjdk-jdk21#59. This PR and ibmruntimes/openj9-openjdk-jdk21#59 will need to be merged together.

fyi @tajila

@babsingh
Copy link
Contributor Author

babsingh commented Nov 8, 2023

@hangshao0 Requesting your review.

@tajila
Copy link
Contributor

tajila commented Nov 8, 2023

Are these state changes safe for jdk21? ie. are they JDK22+

@babsingh
Copy link
Contributor Author

babsingh commented Nov 8, 2023

Are these state changes safe for jdk21? ie. are they JDK22+

Yes, it fixes a bug, which also exists in JDK21. See https://bugs.openjdk.org/browse/JDK-8312498 for more details.

Copy link
Contributor

@hangshao0 hangshao0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hangshao0
Copy link
Contributor

Jenkins test sanity.functional,sanity.openjdk aix jdk21 depends ibmruntimes/openj9-openjdk-jdk21#59

@babsingh
Copy link
Contributor Author

babsingh commented Nov 10, 2023

https://openj9-jenkins.osuosl.org/job/Test_openjdk21_j9_sanity.openjdk_ppc64_aix_Personal_testList_0/10/consoleFull

All PR builds have passed; no test failures are seen. There is an infra issue where the scripts cannot complete because Calling Pipeline was cancelled.

@hangshao0 hangshao0 merged commit f4501d1 into eclipse-openj9:master Nov 10, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants