Part 4 ValueTypeTests for lw5, acmp and synchronization #18415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-m
added
comp:test
project:valhalla
theresa-m
force-pushed
the
valuetypetests_4
branch
from
4abce8b
to
4903ca9
Compare
theresa-m
force-pushed
the
valuetypetests_4
branch
from
4903ca9
to
d99d604
Compare
hangshao0
reviewed
Nov 9, 2023
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeGenerator.java
Outdated
Show resolved
Hide resolved
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeTests.java
Show resolved
Hide resolved
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeTests.java
Show resolved
Hide resolved
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeTests.java
Show resolved
Hide resolved
Add acmp tests to the lw5 version of ValueTypeTests: - testBasicACMPTestOnIdentityTypes - testBasicACMPTestOnValueTypes - testACMPTestOnFastSubstitutableValueTypes - testACMPTestOnFastSubstitutableValueTypesVer2 - testACMPTestOnRecursiveValueTypes - testACMPTestOnValueFloat - testACMPTestOnValueDouble - testACMPTestOnAssortedValues Add synchronization tests including: - testMonitorEnterAndExitOnValueType - testSynchMethodsOnValueTypes - testSynchMethodsOnRefTypes - testMonitorExitWithRefType - testMonitorEnterAndExitWithRefType - createValueTypeWithVolatileFields -> createClassWithVolatileValueTypeFields - modified only to test volatile value types in an identity class. volatile fields cannot exist in a value type since fields are implicitly final. Split ValueTypeGenerator.java to src_qtypes and src_lw5. This is being used for synchronization tests which rely on illegal classes and bytecode patterns that can't be generated with javac. Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
theresa-m
force-pushed
the
valuetypetests_4
branch
from
7f2236b
to
1979328
Compare
hangshao0
approved these changes
Nov 16, 2023
|
Jenkins test sanity,extended winval jdknext |
|
Jenkins test sanity,extended aixval jdknext |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add acmp tests to the lw5 version of ValueTypeTests:
Add synchronization tests including:
Split ValueTypeGenerator.java to src_qtypes and src_lw5. This is being used for synchronization tests which rely on illegal classes and bytecode patterns that can't be generated with javac.
Related: #18157