Part 3 of adding lw5 ValueTypeTests #18348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-m
added
comp:test
project:valhalla
theresa-m
force-pushed
the
valuetypetests_3
branch
2 times, most recently
from
3633eb1
to
975dfd4
Compare
hangshao0
reviewed
Oct 26, 2023
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeTests.java
Outdated
Show resolved
Hide resolved
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeTests.java
Outdated
Show resolved
Hide resolved
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeTests.java
Outdated
Show resolved
Hide resolved
theresa-m
force-pushed
the
valuetypetests_3
branch
from
975dfd4
to
cbb9a94
Compare
|
@theresa-m There is a line ending check failure. |
The following tests are added: testCreateLargeValueObjectAndMegaValueObject testCreateLargeRefObjectAndMegaRefObject testAssortedValueWithLongAlignment testAssortedRefWithLongAlignment testAssortedValueWithObjectAlignment testAssortedRefWithObjectAlignment testAssortedValueWithSingleAlignment testAssortedRefWithSingleAlignment testStaticFieldsWithSingleAlignment testStaticFieldsWithLongAlignment testStaticFieldsWithObjectAlignment testGCFlattenedPoint2DArray testGCFlattenedValueArrayWithSingleAlignment testGCFlattenedValueArrayWithObjectAlignment testGCFlattenedValueArrayWithLongAlignment testGCFlattenedLargeObjectArray testGCFlattenedMegaObjectArray The following tests will never be added to lw5 ValueTypeTests: testInvalidNestedField <- replaced by preload tests in ValhallaAttributeTests testNullWritesOnNonNullableArrays <- this will be added to ValhallaAttributeTests once support exists for nullrestricted arrays testNoneValueQTypeAsNestedField <- replaced by nullrestricted tests in ValhallaAttributeTests withfield tests since this bytecode is being removed: testWithFieldOnNonValueType testWithFieldOnNull testWithFieldOnNonExistentClass isPrimitiveClass tests since the primitive bytecode is going away: testIsPrimitiveClassOnRef testIsPrimitiveClassOnValueType testIsPrimitiveClassOnInterface testIsPrimitiveClassOnAbstractClass testIsPrimitiveOnValueArrayClass testIsPrimitiveOnRefArrayClass Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
theresa-m
force-pushed
the
valuetypetests_3
branch
from
cbb9a94
to
6c4f9d2
Compare
|
Sorry thought I got these all on Friday. The line check is passing now. |
|
Jenkins test sanity,extended winval jdknext |
|
Jenkins test sanity,extended aixval jdknext |
hangshao0
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following tests are added:
testCreateLargeValueObjectAndMegaValueObject
testCreateLargeRefObjectAndMegaRefObject
testAssortedValueWithLongAlignment
testAssortedRefWithLongAlignment
testAssortedValueWithObjectAlignment
testAssortedRefWithObjectAlignment
testAssortedValueWithSingleAlignment
testAssortedRefWithSingleAlignment
testStaticFieldsWithSingleAlignment
testStaticFieldsWithLongAlignment
testStaticFieldsWithObjectAlignment
testGCFlattenedPoint2DArray
testGCFlattenedValueArrayWithSingleAlignment
testGCFlattenedValueArrayWithObjectAlignment
testGCFlattenedValueArrayWithLongAlignment
testGCFlattenedLargeObjectArray
testGCFlattenedMegaObjectArray
The following tests will never be added to lw5 ValueTypeTests:
testInvalidNestedField <- replaced by preload tests in ValhallaAttributeTests testNullWritesOnNonNullableArrays <- this will be added to ValhallaAttributeTests once support exists for nullrestricted arrays testNoneValueQTypeAsNestedField <- replaced by nullrestricted tests in ValhallaAttributeTests
withfield tests since this bytecode is being removed: testWithFieldOnNonValueType
testWithFieldOnNull
testWithFieldOnNonExistentClass
isPrimitiveClass tests since the primitive bytecode is going away: testIsPrimitiveClassOnRef
testIsPrimitiveClassOnValueType
testIsPrimitiveClassOnInterface
testIsPrimitiveClassOnAbstractClass
testIsPrimitiveOnValueArrayClass
testIsPrimitiveOnRefArrayClass