Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split ValueTypeSystemArraycopyTests to src_lw5 and src_qtypes folders #18330

Merged

Conversation

theresa-m
Copy link
Contributor

Modify tests to compile with lw5

Related #18157

@theresa-m theresa-m requested a review from a7ehuo October 23, 2023 14:17
@theresa-m
Copy link
Contributor Author

@a7ehuo can you review my changes to make sure they reflect your intentions for these tests?

Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@hangshao0 hangshao0 added project:valhalla Used to track Project Valhalla related work comp:test labels Oct 23, 2023
@theresa-m theresa-m force-pushed the valuetypesystemarraycopytests branch from 6a31074 to 28ac21e Compare October 23, 2023 14:25
@theresa-m
Copy link
Contributor Author

If you look at the second commit instead of all changes you can see only the changes that were made to the tests.

Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@theresa-m theresa-m force-pushed the valuetypesystemarraycopytests branch from 28ac21e to 2080cbd Compare October 23, 2023 16:03
Copy link
Contributor

@a7ehuo a7ehuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the update! LGTM

@hangshao0
Copy link
Contributor

Jenkins test sanity,extended winval jdknext

@hangshao0 hangshao0 merged commit 06c3abc into eclipse-openj9:master Oct 24, 2023
6 checks passed
@theresa-m theresa-m deleted the valuetypesystemarraycopytests branch December 6, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:test project:valhalla Used to track Project Valhalla related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants