Split ValueTypeTests for lw5 and enable basic value type tests #18317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-m
added
comp:test
project:valhalla
theresa-m
force-pushed
the
valuetypetests_1
branch
from
ddc5d7b
to
3c1e610
Compare
hangshao0
reviewed
Oct 20, 2023
test/functional/Valhalla/src_lw5/org/openj9/test/lworld/ValueTypeTests.java
Outdated
Show resolved
Hide resolved
Refactored tests will be gradually added to lw5 ValueTypeTests. This commit adds: - testCreatePoint2D - testCreatePoint2DComplex - testCreateLine2D - testCreateFlattenedLine2D - testCreateTriangle2D Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
theresa-m
force-pushed
the
valuetypetests_1
branch
2 times, most recently
from
7e5a3d8
to
b2361e7
Compare
hangshao0
reviewed
Oct 20, 2023
Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
theresa-m
force-pushed
the
valuetypetests_1
branch
from
b2361e7
to
b4dc372
Compare
hangshao0
approved these changes
Oct 20, 2023
|
Jenkins test sanity,extended winval jdknext |
|
Jenkins test sanity,extended zlinuxval jdknext |
|
The failure in the PR builds looks related to API changes in the class library the JDKnext. #18296 added the support in JDK22, but Valhalla is still failing. @JasonFengJ9 |
|
JDK head stream merging conflict PRs were just merged today which the Valhalla repo depends on.
Will resolve Valhalla merging conflicts to consume the latest upstream and JDK head stream. |
|
Jenkins test sanity,extended winval jdknext |
|
Jenkins test sanity,extended zlinuxval jdknext |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please go to the third commit to see which tests have been refactored.
Related to #18157