-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify INL frame build in System.arraycopy #17886
Conversation
The arraycopy INL builds a frame for many error cases and the value type case which may require allocation. Simplifying the code so the frame is always built early greatly simplifies the code and corrects a problem introduced in eclipse-openj9#17732 (INL frame build, tear down and rebuild is no longer allowed in general and I missed a case here). It also appear to fix the reported issue, though I'm not entirely sure why. Also fix a missing frame build in the Thread interrupted INL. Fixes: eclipse-openj9#17875 Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
Jenkins test sanity,extended xlinuxval jdknext |
Jenkins test sanity xlinuxvalst jdknext |
jenkins test sanity alinux64 jdk21 |
jenkins compile win jdk11 |
JVMTI failures appear to be either a filesystem issue or a broken exclude mechanism in the testing:
|
The JCL tests fail for more real-looking reasons, but I doubt it has anything to do with this change (is the VT build just stale and broken?). |
It is fixed by |
Jenkins test sanity xlinuxvalst jdknext |
jdknext is JDK22 now - perhaps that's the cause of the failures. |
The JCL tests continue to fail (no surprise since the above fix was only for JVMTI tests): @tajila @JasonFengJ9 Are these failures expected? |
Missed |
@gacholio Could you try another run? |
Jenkins test sanity xlinuxvalst jdknext |
Thanks @JasonFengJ9 - it's passing now. @tajila This is ready to go. |
@JasonFengJ9 Consider automatically propagating the exclude lists (and whatever else is versioned for the JDK level) when a new release is added. While it may be inaccurate, it's certainly better than failing 100s of tests in each new release. |
The arraycopy INL builds a frame for many error cases and the value type case which may require allocation. Simplifying the code so the frame is always built early greatly simplifies the code and corrects a problem introduced in #17732 (INL frame build, tear down and rebuild is no longer allowed in general and I missed a case here). It also appear to fix the reported issue, though I'm not entirely sure why.
Also fix a missing frame build in the Thread interrupted INL.
Fixes: #17875