Atomic-free JNI work #1762
Merged
Atomic-free JNI work #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- re-enable JNI critical for atomic-free - fix JNI check bug related to critical Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
|
jenkins test sanity zlinux jdk8 |
|
jenkins test sanity plinux jdk9 |
| @@ -36,6 +36,10 @@ | |||
| void | |||
| MM_JNICriticalRegion::reacquireAccess(J9VMThread* vmThread, UDATA accessMask) | |||
| { | |||
| #if defined(J9VM_INTERP_ATOMIC_FREE_JNI) | |||
| // Current thread must have entered the VM before acquiring exclusive | |||
There was a problem hiding this comment.
I am wondering if these asserts could be enabled all of the time? Not asking you to change them just thinking out loud.
There was a problem hiding this comment.
The flag has no meaning unless the ifdef is true.
There was a problem hiding this comment.
Sorry thought that was a VMAccess check lol. My bad!
| hasVMAccess = true; | ||
| #else /* J9VM_INTERP_ATOMIC_FREE_JNI */ | ||
| MM_JNICriticalRegion::enterCriticalRegion(vmThread); | ||
| if (!hasVMAccess) { |
There was a problem hiding this comment.
Also just making a note for myself to come look at the hasVMAccess. Not sure how one thread entering here could have it and another thread not have it.
There was a problem hiding this comment.
I suspect this code can be refactored/optimized at some point.
charliegracie
approved these changes
Apr 25, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Graham Chapman graham_chapman@ca.ibm.com