Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Split List Forced Flag + Revert CRIU Thread Count Reinit #17459

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

RSalman
Copy link
Contributor

@RSalman RSalman commented May 27, 2023

  • Set list split forced flags during cmdline parsing, now required by upstream GC params init API.
  • Revert GC thread count init behaviour: recompute the default thread count when the explicit thread count is invalid.

Signed-off-by: Salman Rana salman.rana@ibm.com

@RSalman
Copy link
Contributor Author

RSalman commented May 27, 2023

Depends on eclipse-omr/omr#7009

@RSalman RSalman force-pushed the enable-opt-reinit branch 3 times, most recently from 78dbb9d to 7fefc89 Compare May 27, 2023 05:30
@RSalman RSalman changed the title Reinit GC Scavenger for Restore (CRIU) Reinit GC Params and Scavenger for Restore (CRIU) May 27, 2023
@dmitripivkine dmitripivkine added comp:gc criu Used to track CRIU snapshot related work labels May 29, 2023
@RSalman
Copy link
Contributor Author

RSalman commented May 29, 2023

@amicic please review

@RSalman RSalman force-pushed the enable-opt-reinit branch 2 times, most recently from 88bc6b6 to 4407eaa Compare June 14, 2023 17:54
RSalman added a commit to RSalman/omr that referenced this pull request Jun 14, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
@RSalman RSalman changed the title Reinit GC Params and Scavenger for Restore (CRIU) Reinit GC Params for Restore (CRIU) Jun 14, 2023
RSalman added a commit to RSalman/omr that referenced this pull request Jun 15, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
RSalman added a commit to RSalman/omr that referenced this pull request Jun 15, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
RSalman added a commit to RSalman/omr that referenced this pull request Jun 15, 2023
Required for downstream OpenJ9 Changes. See
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
RSalman added a commit to RSalman/omr that referenced this pull request Jun 15, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
@RSalman RSalman requested a review from amicic June 15, 2023 18:55
@RSalman RSalman changed the title Reinit GC Params for Restore (CRIU) Update Split List Forced Flag + Revert CRIU Thread Count Reinit Behaviour Jun 15, 2023
@RSalman RSalman changed the title Update Split List Forced Flag + Revert CRIU Thread Count Reinit Behaviour Update Split List Forced Flag + Revert CRIU Thread Count Reinit Jun 15, 2023
RSalman added a commit to RSalman/omr that referenced this pull request Jun 15, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
RSalman added a commit to RSalman/omr that referenced this pull request Jun 15, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
- Set list split forced flags during cmdline parsing, now required by
upstream GC params init API.
- Revert GC thread count init behaviour: recompute the default thread
count when the explicit thread count is invalid.

Signed-off-by: Salman Rana <salman.rana@ibm.com>
@RSalman
Copy link
Contributor Author

RSalman commented Jun 16, 2023

Depends on eclipse-omr/omr#7035

RSalman added a commit to RSalman/omr that referenced this pull request Jun 16, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
RSalman added a commit to RSalman/omr that referenced this pull request Jun 16, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
RSalman added a commit to RSalman/omr that referenced this pull request Jun 16, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
@amicic
Copy link
Contributor

amicic commented Jun 19, 2023

Jenkins test sanity xlinuxcriu jdk17

@amicic
Copy link
Contributor

amicic commented Jun 19, 2023

jenkins compile win32,aix jdk8

@amicic amicic merged commit 963256e into eclipse-openj9:master Jun 20, 2023
jonoommen pushed a commit to jonoommen/omr that referenced this pull request Jun 20, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
jonoommen pushed a commit to jonoommen/omr that referenced this pull request Jun 20, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
RSalman added a commit to RSalman/openj9-omr that referenced this pull request Jun 22, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
RSalman added a commit to RSalman/openj9-omr that referenced this pull request Jun 22, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
rmnattas pushed a commit to rmnattas/omr that referenced this pull request Nov 7, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
rmnattas pushed a commit to rmnattas/omr that referenced this pull request Nov 7, 2023
Relates to
eclipse-openj9/openj9#17459 (comment)

Signed-off-by: Salman Rana <salman.rana@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:gc criu Used to track CRIU snapshot related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants