-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jvmtiGetStackTrace #17318
Merged
gacholio
merged 1 commit into
eclipse-openj9:master
from
babsingh:fix_jvmtiGetStackTrace
May 2, 2023
Merged
Fix jvmtiGetStackTrace #17318
gacholio
merged 1 commit into
eclipse-openj9:master
from
babsingh:fix_jvmtiGetStackTrace
May 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haltThreadForInspection can release VM access. So, threadObject should be set after haltThreadForInspection to stop the GC from relocating it. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
force-pushed
the
fix_jvmtiGetStackTrace
branch
from
May 2, 2023 03:38
6c7ba65
to
916ac8e
Compare
jenkins test sanity zlinux jdk20 |
@gacholio Can you please review/merge this PR? |
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
May 2, 2023
- NotSuspended/GetStackTraceNotSuspendedStressTest has been fixed. - SuspendThread/suspendthrd03 has been removed in JDK20. - Now, VThreadTest fails because of eclipse-openj9/openj9#15920. Related: - eclipse-openj9/openj9#16688 - eclipse-openj9/openj9#16242 - eclipse-openj9/openj9#17307 Depends on eclipse-openj9/openj9#17318 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
gacholio
approved these changes
May 2, 2023
The build is blocked trying to find hardware. |
Failed test is JIT server, which is unrelated to this change. |
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
May 2, 2023
- NotSuspended/GetStackTraceNotSuspendedStressTest has been fixed. - SuspendThread/suspendthrd03 has been removed in JDK20. - Now, VThreadTest fails because of eclipse-openj9/openj9#15920. - eclipse-openj9/openj9#16185 and eclipse-openj9/openj9#16279 are permanently excluded. Changed their reason to adoptium#1297 to support the test tool, which automatically enables tests after the related issues are closed. Related: - eclipse-openj9/openj9#16688 - eclipse-openj9/openj9#16242 - eclipse-openj9/openj9#17307 Depends on eclipse-openj9/openj9#17318 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
llxia
added a commit
to adoptium/aqa-tests
that referenced
this pull request
May 2, 2023
- NotSuspended/GetStackTraceNotSuspendedStressTest has been fixed. - SuspendThread/suspendthrd03 has been removed in JDK20. - Now, VThreadTest fails because of eclipse-openj9/openj9#15920. - eclipse-openj9/openj9#16185 and eclipse-openj9/openj9#16279 are permanently excluded. Changed their reason to #1297 to support the test tool, which automatically enables tests after the related issues are closed. Related: - eclipse-openj9/openj9#16688 - eclipse-openj9/openj9#16242 - eclipse-openj9/openj9#17307 Depends on eclipse-openj9/openj9#17318 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com> Co-authored-by: Martijn Verburg <martijnverburg@gmail.com> Co-authored-by: Lan Xia <19273206+llxia@users.noreply.github.com>
Please make a 0.39 PR for this |
Already included in 0.39. The commit message, Fix jvmtiGetStackTrace, shows up in the v0.39.0-release commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
haltThreadForInspection
can release VM access. So,threadObject
shouldbe set after
haltThreadForInspection
to stop the GC from relocating it.Related: #16688