Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jvmtiGetStackTrace #17318

Merged
merged 1 commit into from
May 2, 2023

Conversation

babsingh
Copy link
Contributor

@babsingh babsingh commented May 2, 2023

haltThreadForInspection can release VM access. So, threadObject should
be set after haltThreadForInspection to stop the GC from relocating it.

Related: #16688

haltThreadForInspection can release VM access. So, threadObject should
be set after haltThreadForInspection to stop the GC from relocating it.

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh
Copy link
Contributor Author

babsingh commented May 2, 2023

jenkins test sanity zlinux jdk20

@babsingh
Copy link
Contributor Author

babsingh commented May 2, 2023

@gacholio Can you please review/merge this PR?

babsingh added a commit to babsingh/aqa-tests that referenced this pull request May 2, 2023
- NotSuspended/GetStackTraceNotSuspendedStressTest has been fixed.
- SuspendThread/suspendthrd03 has been removed in JDK20.
- Now, VThreadTest fails because of eclipse-openj9/openj9#15920.

Related:
- eclipse-openj9/openj9#16688
- eclipse-openj9/openj9#16242
- eclipse-openj9/openj9#17307

Depends on eclipse-openj9/openj9#17318

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@gacholio
Copy link
Contributor

gacholio commented May 2, 2023

The build is blocked trying to find hardware.

@gacholio
Copy link
Contributor

gacholio commented May 2, 2023

Failed test is JIT server, which is unrelated to this change.

@gacholio gacholio merged commit c5e24ed into eclipse-openj9:master May 2, 2023
babsingh added a commit to babsingh/aqa-tests that referenced this pull request May 2, 2023
- NotSuspended/GetStackTraceNotSuspendedStressTest has been fixed.
- SuspendThread/suspendthrd03 has been removed in JDK20.
- Now, VThreadTest fails because of eclipse-openj9/openj9#15920.
- eclipse-openj9/openj9#16185 and eclipse-openj9/openj9#16279 are
permanently excluded. Changed their reason to adoptium#1297 to support
the test tool, which automatically enables tests after the related
issues are closed.

Related:
- eclipse-openj9/openj9#16688
- eclipse-openj9/openj9#16242
- eclipse-openj9/openj9#17307

Depends on eclipse-openj9/openj9#17318

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
llxia added a commit to adoptium/aqa-tests that referenced this pull request May 2, 2023
- NotSuspended/GetStackTraceNotSuspendedStressTest has been fixed.
- SuspendThread/suspendthrd03 has been removed in JDK20.
- Now, VThreadTest fails because of eclipse-openj9/openj9#15920.
- eclipse-openj9/openj9#16185 and eclipse-openj9/openj9#16279 are
permanently excluded. Changed their reason to #1297 to support
the test tool, which automatically enables tests after the related
issues are closed.

Related:
- eclipse-openj9/openj9#16688
- eclipse-openj9/openj9#16242
- eclipse-openj9/openj9#17307

Depends on eclipse-openj9/openj9#17318

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
Co-authored-by: Lan Xia <19273206+llxia@users.noreply.github.com>
@tajila
Copy link
Contributor

tajila commented May 16, 2023

Please make a 0.39 PR for this

@babsingh
Copy link
Contributor Author

Please make a 0.39 PR for this

Already included in 0.39. The commit message, Fix jvmtiGetStackTrace, shows up in the v0.39.0-release commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants