Fix jvmtiGetVirtualThread and make it more robust #16787
Merged
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no virtual thread is mounted on the targetThread i.e. carrierThreadObject == threadObject, then return null for the output virtual thread value. Virtual thread is not pinned in this function. So, read threadObject and carrierThreadObject once and store their values to avoid inconsistency. Related: eclipse-openj9#16688 Related: eclipse-openj9#16751 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
gacholio
approved these changes
Mar 1, 2023
|
jenkins test sanity zlinux jdk19 |
keithc-ca
reviewed
Mar 1, 2023
babsingh
added a commit
to babsingh/openj9
that referenced
this pull request
Mar 1, 2023
Related: eclipse-openj9#16787 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no virtual thread is mounted on the targetThread i.e.
carrierThreadObject == threadObject, then return null
for the output virtual thread value.
Virtual thread is not pinned in this function. So, read
threadObject and carrierThreadObject once and store
their values to avoid inconsistency.
Related: #16688
Related: #16751