Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check VFE1 feature instead of flag when generating Math.fma on Z #15585

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Check VFE1 feature instead of flag when generating Math.fma on Z #15585

merged 1 commit into from
Jul 21, 2022

Conversation

Spencer-Comin
Copy link
Contributor

Patch to use VFE1 feature instead of flag when checking if vector FMA is supported.

See discussion at eclipse-omr/omr#6615 as to why this is necessary.

@Spencer-Comin
Check VFE1 feature in Math.fma codegen
71ac86e 
Use VFE1 feature instead of flag when checking if VFMA is supported.

Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
r30shah
r30shah approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@r30shah r30shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you please upload the instructions generated with this change here to make sure that we do generate VFMA?

@joransiu
Copy link
Member

jenkins test sanity zlinux jdk8,jdk11,jdk17

@Spencer-Comin
Copy link
Contributor Author

Same test as eclipse-omr/omr#6615 (comment)

 n7n      (  0)  treetop                                                                              [     0x3ff55502770] bci=[-1,3,6] rc=0 vc=433 vn
 n6n      (  1)    fcall  java/lang/Math.fma(FFF)F[#389  final static Method] [flags 0x20500 0x0 ] (in FPR_0035) ()  [     0x3ff55502720] bci=[-1,3,6]
 n44n     (  0)      ==>fRegLoad (in FPR_0034) (SeenRealReference )
 n43n     (  0)      ==>fRegLoad (in FPR_0033) (SeenRealReference )
 n42n     (  0)      ==>fRegLoad (in FPR_0032) (SeenRealReference )
------------------------------

 [     0x3ff556501f0]                          VFMADB  FPR_0035,FPR_0034,FPR_0033,FPR_0032

@joransiu joransiu merged commit d0075e6 into eclipse-openj9:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r30shah r30shah r30shah approved these changes

@joransiu joransiu joransiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Spencer-Comin @joransiu @r30shah