Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always call classMatchesCachedVersion in rememberClass #15037

Merged
merged 1 commit into from
May 12, 2022
+9 −1
Merged

Always call classMatchesCachedVersion in rememberClass #15037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion runtime/compiler/env/J9SharedCache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,7 +885,15 @@ TR_J9SharedCache::rememberClass(J9Class *clazz, const AOTCacheClassChainRecord *
chainData = findChainForClass(clazz, key, keyLength);
if (chainData != NULL)
{
LOG(1, "\tchain exists (%p) so nothing to store\n", chainData);
if (classMatchesCachedVersion(clazz, chainData))
{
LOG(1, "\tcurrent class and class chain found (%p) are identical; returning the class chain\n", chainData);
}
else
{
LOG(1, "\tcurrent class and class chain found (%p) do not match, so cannot use class chain; returning NULL\n", chainData);
chainData = NULL;
}
return chainData;
}

Expand Down