Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameters to run specific aqa-tests releases #14257

Merged
merged 3 commits into from
Jan 17, 2022
Merged

Add parameters to run specific aqa-tests releases #14257

merged 3 commits into from
Jan 17, 2022

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Jan 12, 2022 •
edited
Loading

  • Add USE_TESTENV_PROPERTIES
  • Remove ADOPTOPENJDK${release}_REPO logic as it is not used and it complicates the logic for consuming user-provided ADOPTOPENJDK_REPO and ADOPTOPENJDK_BRANCH

Related: runtimes/infrastructure/issues/6390 and adoptium/aqa-tests#2347

Signed-off-by: lanxia lan_xia@ca.ibm.com

@llxia llxia force-pushed the test2 branch 3 times, most recently from 5d0297e to 8ce12b8 Compare January 14, 2022 17:09
@llxia
Add USE_TESTENV_PROPERTIES for releases
71a0bdb 
Related: runtimes/infrastructure/issues/6390 and adoptium/aqa-tests#2347

Signed-off-by: lanxia <lan_xia@ca.ibm.com>
@llxia
Remove ADOPTOPENJDK_REPO and BRANCH
58236e0 
Signed-off-by: lanxia <lan_xia@ca.ibm.com>
@llxia
Remove debugging msg and update copyright
692f9df 
Signed-off-by: lanxia <lan_xia@ca.ibm.com>
@llxia
Copy link
Contributor Author

llxia commented Jan 14, 2022 •
edited
Loading

Parameters Build Comment
ADOPTOPENJDK_REPO=https://github.com/llxia/openjdk-tests.git
ADOPTOPENJDK_BRANCH=test2
USE_TESTENV_PROPERTIES=true		 https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-Personal/91 use testenv.properties image https://openj9-jenkins.osuosl.org/job/Test_openjdk11_j9_sanity.functional_x86-64_linux_Personal_testList_0/124/
ADOPTOPENJDK_REPO=empty
ADOPTOPENJDK_BRANCH=empty
USE_TESTENV_PROPERTIES=false		 https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-Personal/92 default values

@llxia llxia changed the title Add USE_TESTENV_PROPERTIES for releases Add parameters to run specific aqa-tests releases Jan 14, 2022
@llxia
Copy link
Contributor Author

llxia commented Jan 17, 2022

Please note, once USE_TESTENV_PROPERTIES is set to true, the test pipeline will use the values that are defined in testenv.properties (except ADOPTOPENJDK_REPO and ADOPTOPENJDK_BRANCH).

@llxia llxia marked this pull request as ready for review January 17, 2022 14:33
@llxia llxia requested a review from pshipton January 17, 2022 14:33
@pshipton pshipton merged commit 139b3ad into eclipse-openj9:master Jan 17, 2022
@llxia llxia mentioned this pull request Jan 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamBrousseau AdamBrousseau AdamBrousseau left review comments

@pshipton pshipton pshipton approved these changes

Assignees
No one assigned
Labels
comp:build comp:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llxia @AdamBrousseau @pshipton