Enabled Global Lock Reservation by default on Power #12125
Conversation
|
Pls create a doc issue and PR as well. |
|
Minor nit: please fix spelling of "Reservation" in the commit titles |
IBMJimmyk
changed the title
|
Okay, I'll fix the commit title and open the doc issue and PR. |
|
Jenkins test sanity all jdk8,jdk11 |
|
Jenkins test sanity,sanity.system,extended.system,sanity.openjdk plinux,aix jdk8,jdk11 |
|
jenkins compile win jdk8 |
|
I stopped the original PR test and re-ran more testing only for plinux and AIX since these are the platforms affected. Ignore the xlinux and zlinux build failures, as they are just cancelled jobs. |
|
The CheckZombieLockTest failures in AIX openjdk testing are a known issue #9186 |
|
Thanks for the heads up. |
|
Not sure about the cmdLineTester_jvmtitests_hcr_1 failure. |
|
The grinder failed 1/5. |
|
20x grinder without this change passed https://ci.eclipse.org/openj9/job/Grinder/1548 |
|
Trying 20x with this change to get a better picture of the failure rate https://ci.eclipse.org/openj9/job/Grinder/1549/ |
|
Also 50x without the change https://ci.eclipse.org/openj9/job/Grinder/1550/ |
|
with change 1/20 |
|
I'm currently taking a look to see what the problem is. |
|
The grinders without the change all passed. However, with the change there were 14/100 failures. So there definitely seems to be a problem here. |
|
The hanging issue in I rebased my changes to include the fix and reran to failing test with no problems to verify that the problem is gone. |
Global Lock Reservation is now enabled by default on Power. This is the same behavior as if the -XX:+GlobalLockReservation option was used. To use the previous form of lock reservation, Global Lock Reservation can be disabled with the option -XX:-GlobalLockReservation. Global Lock Reservation is not supported on other platforms so this change only affects Power. Updated documentation and comments to reflect Global Lock Reservation now being on by default on Power. Issue: eclipse-openj9#11424 Signed-off-by: jimmyk <jimmyk@ca.ibm.com>
|
Jenkins test sanity,sanity.system,extended.system,sanity.openjdk plinux,aix jdk8,jdk11 |
|
@pshipton i added the comment to re-test, and it seemed tests are not initiated. |
|
I see stuff running now. Sometimes it's slow, or occasionally ignored and you just need to try again after a few minutes. |
|
The failing checks look like infrastructure issues to me: The actual tests themselves pass. |
|
@IBMJimmyk Can you please open a docs issue/PR, as mentioned in #12125 (comment), thanks. |
|
Yes, I can do that. |
Global Lock Reservation is now enabled by default on Power. This is the same
behavior as if the -XX:+GlobalLockReservation option was used. To use the
previous form of lock reservation, Global Lock Reservation can be disabled
with the option -XX:-GlobalLockReservation.
Global Lock Reservation is not supported on other platforms so this change
only affects Power.
Updated documentation and comments to reflect Global Lock Reservation now
being on by default on Power.
Closes: #11424
Signed-off-by: jimmyk jimmyk@ca.ibm.com