Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tracing for 9416 #12058

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Fix tracing for 9416 #12058

merged 1 commit into from
Feb 26, 2021

Conversation

dsouzai
Copy link
Contributor

@dsouzai dsouzai commented Feb 25, 2021

When the tracing to debug #9416 was first added, a minor change was
missed that would allow the tracing of rememberClass. This commit fixes
it so that the tracing is enabled.

Signed-off-by: Irwin D'Souza dsouzai.gh@gmail.com

When the tracing to debug 9416 was first added, a minor change was
missed that would allow the tracing of rememberClass. This commit fixes
it so that the tracing is enabled.

Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
@dsouzai
Copy link
Contributor Author

dsouzai commented Feb 25, 2021

@0xdaryl could you please review/merge.

@0xdaryl
Copy link
Contributor

0xdaryl commented Feb 26, 2021

Jenkins test sanity xlinux jdk11

@0xdaryl
Copy link
Contributor

0xdaryl commented Feb 26, 2021

Change looks ok. Sadly, the problem hasn't appeared once (to my knowledge) since this tracing was introduced.

@0xdaryl 0xdaryl self-assigned this Feb 26, 2021
@dsouzai
Copy link
Contributor Author

dsouzai commented Feb 26, 2021

It failed once, in my PR build; that's how I realized the missing tracing :/ (see #9416 (comment))

@0xdaryl 0xdaryl merged commit 2bd6189 into eclipse-openj9:master Feb 26, 2021
@dsouzai dsouzai deleted the fixTracing branch February 3, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants