Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build break on Power #10604

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Fix build break on Power #10604

merged 1 commit into from
Sep 16, 2020

Conversation

harryyu1994
Copy link
Contributor

@harryyu1994 harryyu1994 commented Sep 15, 2020 •
edited
Loading

This change fixes the build break caused by this change eclipse-omr/omr#5547

Signed-off-by: Harry Yu harryyu1994@gmail.com

@harryyu1994 harryyu1994 mentioned this pull request Sep 15, 2020
Merged
@harryyu1994
Fix CPU detection bug on Power
4ff2d54 
Signed-off-by: Harry Yu <harryyu1994@gmail.com>
@fjeremic
Copy link
Contributor

Jenkins test sanity plinux,aix jdk11

mpirvu
mpirvu approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewcraik
Copy link
Contributor

Looks like OMR acceptance is broken without this - whoever merges - could you launch and acceptance as well please?

@gita-omr
Copy link
Contributor

Was it a bug or cleaning up some old code? Could you please provide a bit more context?

@mpirvu
Copy link
Contributor

mpirvu commented Sep 15, 2020

@gita-omr Since this is Power related, could you please review/approve this PR? Thanks

@harryyu1994
Copy link
Contributor Author

Was it a bug or cleaning up some old code? Could you please provide a bit more context?

I accidentally broke the openj9 build while cleaning up old cpu processor detection code. The offending change is here eclipse-omr/omr#5547. I renamed one of the APIs and made it private in omr, and that caused a build break in openj9.

@harryyu1994 harryyu1994 changed the title Fix CPU detection bug on Power Fix build break on Power Sep 15, 2020
@harryyu1994
Copy link
Contributor Author

Was it a bug or cleaning up some old code? Could you please provide a bit more context?

Old code cleanup is still ongoing, this is just a quick fix to unblock omr acceptance.

@mpirvu mpirvu merged commit 1d44c6a into eclipse-openj9:master Sep 16, 2020
@harryyu1994 harryyu1994 deleted the fixFailureOnPower branch September 16, 2020 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gita-omr gita-omr gita-omr approved these changes

@mpirvu mpirvu mpirvu approved these changes

@fjeremic fjeremic fjeremic approved these changes

Assignees
No one assigned
Labels
arch:power comp:jit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harryyu1994 @fjeremic @andrewcraik @gita-omr @mpirvu