Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor allowGuardMerging() to the common codegen #10090

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Refactor allowGuardMerging() to the common codegen #10090

merged 1 commit into from
Jul 6, 2020

Conversation

dchopra001
Copy link
Contributor

Signed-off-by: Dhruv Chopra Dhruv.C.Chopra@ibm.com

@dchopra001
Copy link
Contributor Author

See eclipse-omr/omr#4456 for related OMR PR.

@fjeremic Can I get a review please?

This was referenced Jul 6, 2020
Closed
Merged
@dchopra001
Copy link
Contributor Author

Note: I have verified these tests with internal builds w.r.t JITServer testing. Except for an existing issue, the builds are stable for: _sanity.functional.regular, _sanity.functional.native, and also for cold/warm runs of AcmeAir. (Mentioning this here since JITServer on Z is not stable in upstream yet, we won't be able to run testing for it.)

mpirvu
mpirvu approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu
Copy link
Contributor

mpirvu commented Jul 6, 2020 

../../../../../openj9/runtime/compiler/codegen/CodeGenGPU.cpp:1300:1: error: static assertion failed: Number of elements in nvvmOpCodeNames does not match the value of TR::NumIlOps

Maybe you need a rebase?

@mpirvu mpirvu added the comp:jit label Jul 6, 2020
@mpirvu mpirvu self-assigned this Jul 6, 2020
@dchopra001
Refactor allowGuardMerging() to the common codegen
47677d9 
Signed-off-by: Dhruv Chopra <Dhruv.C.Chopra@ibm.com>
@dchopra001
Copy link
Contributor Author

Trying a rebase. I think 91f2a08 should fix it.

@mpirvu
Copy link
Contributor

mpirvu commented Jul 6, 2020

jenkins test sanity all jdk11

@mpirvu mpirvu merged commit d31be0b into eclipse-openj9:master Jul 6, 2020
@dchopra001 dchopra001 deleted the allowGuardMergeRefactor branch July 13, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpirvu mpirvu mpirvu approved these changes

Assignees

@mpirvu mpirvu

Labels
comp:jit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dchopra001 @mpirvu