-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove allocation prefetch experimental code #9038
Comments
Similarly, in AllocPrefetchSnippet.cpp any code that would become active if this option were to be active is now dead. This means removing the Repeat this process of assuming the option is false and removing/folding code accordingly for each reference to this feature you find in the code. Once it has been removed from OpenJ9, you can remove the |
@jmesyou : please complete this |
I asked @BradleyWood to investigate TLH prefetching performance, so this cleanup work could be done as part of that investigation (unless you have a PR imminent for this @jmesyou). |
Issue: eclipse-openj9#9038 Signed-off-by: Bradley Wood <bradley.wood@ibm.com>
Issue: eclipse-openj9/openj9#9038 Signed-off-by: Bradley Wood <bradley.wood@ibm.com>
Issue: eclipse-openj9/openj9#9038 Signed-off-by: Bradley Wood <bradley.wood@ibm.com>
Issue: eclipse-openj9/openj9#9038 Signed-off-by: Bradley Wood <bradley.wood@ibm.com>
There was an experimental allocation prefetch strategy implemented more than a decade ago (I think it was mine!) that was never enabled and never went past the experimental stage. It has long been deprecated. Remove it.
Look for code guarded with
TR_EnableNewX86PrefetchTLH
and remove dead code produced from that exercise. A followup PR in OMR to remove the option is in order as well.The text was updated successfully, but these errors were encountered: