-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PR testing for JITServer with the master branch #7782
Comments
We should be using the |
Yes. When I originally said new spec with extra env variable I didn't know about the work to add the new configure option. It would be a dup spec with one more config option. I would prefer to add this after #7809 is merged but I'm not sure if that will land in time for this work. |
Few things to confirm.
ie. You would then be able to do
Instead of
The side effect is you can only have jitserver testing on jitserver specs. Which I assume would be the case but please confirm. Note to self, this mechanism is still used for If we did want separate test jobs, we may need to pass a different |
Do not believe there is any reason to having separate test job names, because these test jobs would be related to a parent pipelines that is jitserver specific (and so can be found & queried in jenkins & trss from parent jitserver build, fyi @llxia). If you did want that, do not override JDK_IMPL or any of the core parameters that have a specific meaning and usage in underlying scripts (as it would have disastrous effects). If different name needed, recommendation would be to use a different SUFFIX a parameter that exists only to allow for different job names (currently _Nightly, _Release and _personal). |
I don't have a preference for the options above. |
- Adds ability to compile with the JITServer flag (--enable-jitserver=yes). - Adds ability to set TEST_FLAG for all test targets via variable file. - Set TEST_FLAG=JITAAS via variable file instead of having to pass it with the test target. - Still leave the option to set a TEST_FLAG via adding +FLAG to the test target name as this is used for +aot. - Add JITServer specs for x/p/z Linux. Fixes eclipse-openj9#7782 [skip ci] Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
Currently we can do PR testing for the JITServer with the jittas branch with a comment like:
Jenkins test sanity.functional+jitaas xlinux jdk8,jdk11 depends eclipse/openj9-omr#jitaas
We would like to have the same functionality for the master branch as well, but in the master branch the JITServer code is protected by
#ifdef JITSERVER_SUPPORT
.One possibility is to set the following env var:
JITSERVER_SUPPORT=1
whenever+jitaas
is seen in the comment that triggers the testing.@AdamBrousseau proposed a better alternative: create new platform/spec on the compile side similar to how we do compressed vs XL. This is going to be a duplicate spec with an extra env variable.
The text was updated successfully, but these errors were encountered: