Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK21 serviceability/jvmti/vthread/ForceEarlyReturnTest/ForceEarlyReturnTest.java#no-vmcontinuations RuntimeException: ForceEarlyReturnTest failed! #17713

Closed
JasonFengJ9 opened this issue Jun 29, 2023 · 1 comment · Fixed by adoptium/aqa-tests#4688

Comments

@JasonFengJ9
Copy link
Member

JasonFengJ9 commented Jun 29, 2023

Failure link

From an internal build(rhel8x86-rtp-rt2-1):

08:24:53  openjdk version "21-internal" 2023-09-19
08:24:53  OpenJDK Runtime Environment (build 21-internal-adhoc.jenkins.BuildJDK21x86-64linuxPersonal)
08:24:53  Eclipse OpenJ9 VM (build master-163a51495d5, JRE 21 Linux amd64-64-Bit Compressed References 20230624_7 (JIT enabled, AOT enabled)
08:24:53  OpenJ9   - 163a51495d5
08:24:53  OMR      - 59b55e30960
08:24:53  JCL      - e76b3946ed5 based on jdk-21+27)

Rerun in Grinder - Change TARGET to run only the failed test targets.

Optional info

Failure output (captured from console output)

08:27:16  variation: Mode150
08:27:16  JVM_OPTIONS:  -XX:+UseCompressedOops 

08:34:03  STDOUT:
08:34:03  Agent init
08:34:03  Main: prepareAgent started
08:34:03  Main: prepareAgent finished
08:34:03  
08:34:03  Main #A: method A() must be blocked on entering a synchronized statement
08:34:03  TestTask.run: started
08:34:03  TestTask.A: started
08:34:03  
08:34:03  Main #A.1: unsuspended
08:34:03  Main: forceEarlyReturn: ForceEarlyReturnInt returned code: JVMTI_ERROR_OPAQUE_FRAME (32)
08:34:03  
08:34:03  FAILED: Main #A.1: expected THREAD_NOT_SUSPENDED instead of: 32
08:34:03  STDERR:
08:34:03  java.lang.RuntimeException: ForceEarlyReturnTest failed!
08:34:03  	at ForceEarlyReturnTest.throwFailed(ForceEarlyReturnTest.java:88)
08:34:03  	at ForceEarlyReturnTest.run(ForceEarlyReturnTest.java:120)
08:34:03  	at ForceEarlyReturnTest.main(ForceEarlyReturnTest.java:93)
08:34:03  	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
08:34:03  	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
08:34:03  	at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138)
08:34:03  	at java.base/java.lang.Thread.run(Thread.java:1595)
08:34:03  
08:34:03  JavaTest Message: Test threw exception: java.lang.RuntimeException: ForceEarlyReturnTest failed!

08:30:44  Test results: passed: 118; failed: 7
08:30:53  Report written to /home/jenkins/workspace/Test_openjdk21_j9_extended.openjdk_x86-64_linux_Personal/jvmtest/openjdk/report/html/report.html
08:30:53  Results written to /home/jenkins/workspace/Test_openjdk21_j9_extended.openjdk_x86-64_linux_Personal/aqa-tests/TKG/output_16876095876025/serviceability_jvmti_j9_0/work
08:30:53  Error: Some tests failed or other problems occurred.
08:30:53  -----------------------------------
08:30:53  serviceability_jvmti_j9_0_FAILED

Created from

FYI @babsingh

@JasonFengJ9 JasonFengJ9 added this to the Java 21 milestone Jun 29, 2023
@babsingh babsingh self-assigned this Jun 30, 2023
babsingh added a commit to babsingh/openj9 that referenced this issue Jul 27, 2023
Previously, ForceEarlyReturn returned JVMTI_ERROR_OPAQUE_FRAME for a
virtual thread.

In JDK21, ForceEarlyReturn includes support for virtual threads as
per the JVMTI specification:
- Error if a virtual thread is not suspended and not the current
  thread.
- Error if a virtual thread is unmounted since it won't be able to
  force an early return.
- For a carrier thread with a virtual thread mounted, the details of
  the carrier thread are derived from targetThread->currentContinuation.

Also, there is no need to halt and resume a thread for inspection since
ForceEarlyReturn expects the thread to be suspended as per the JVMTI
spec. If a thread is not suspended,
it returns JVMTI_ERROR_THREAD_NOT_SUSPENDED.

Related: eclipse-openj9#17713

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh added a commit to babsingh/aqa-tests that referenced this issue Jul 28, 2023
eclipse-openj9/openj9#17874 fixes ForceEarlyReturnTest.

Closes eclipse-openj9/openj9#17713

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh
Copy link
Contributor

babsingh commented Jul 28, 2023

#17874 fixes ForceEarlyReturnTest. The test is re-enabled via adoptium/aqa-tests#4688.

llxia pushed a commit to adoptium/aqa-tests that referenced this issue Jul 28, 2023
eclipse-openj9/openj9#17874 fixes ForceEarlyReturnTest.

Closes eclipse-openj9/openj9#17713

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants