-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JEP 397 Sealed Classes (Second Preview) #11273
Comments
https://mail.openjdk.java.net/pipermail/amber-spec-experts/2020-May/002161.html Some updates
|
I think these changes will be merged sometime next week. |
@ChengJin01 Can you please take a look at this |
I went through all these Specs mentioned above against the JEP360 related Specs at It seems the only updated descriptions related to Sealed Classes to be addressed in terms of VM is the check of sealed superclass/superinterface in http://cr.openjdk.java.net/~gbierman/jep397/jep397-20201104/specs/sealed-classes-jvms.html as follows:
Actually these check were already mentioned in JEP 360 https://openjdk.java.net/jeps/360 but not yet emphasized in the corresponding
I will get started to prepare the code involved and hopefully they should capture all expected errors in these latest test suites in OpenJDK16. |
The code is pretty much ready at ChengJin01@b49212b. |
fyi #11405 |
As for #11405, there is probably no change from VM perspective given it only mentioned about the compiler (javac). Will wait & see how it goes in the latest jtreg test suites. |
Note that Class.permittedSubclasses() was renamed to getPermittedSubclasses(). http://cr.openjdk.java.net/~iris/se/16/build/latest/diffsFrom15%2b36/java.base/java/lang/Class.html |
This is tracked in #10977. @mikezhang1234567890 will be looking at it. |
We have delivered all items for this feature. |
The change is to add more check on the sealed classes specified in JEP397: Sealed Classes (Second Preview) Related: eclipse-openj9#11273 Signed-off-by: Cheng Jin <jincheng@ca.ibm.com>
The change is to add more check on the sealed classes specified in JEP397: Sealed Classes (Second Preview) Related: eclipse-openj9#11273 Signed-off-by: Cheng Jin <jincheng@ca.ibm.com>
See https://openjdk.java.net/jeps/397
The text was updated successfully, but these errors were encountered: