Skip to content

Commit

Permalink
Rename Continuation.execute to match the RI
Browse files Browse the repository at this point in the history
Continuation.execute is renamed to Continuation.enter.

Matching the RI will allow us to run more OpenJDK tests without
tweaking them for our implementation and be better prepared to
support unimplemented/new features in the future.

Related: #16688
Related: #16751

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
  • Loading branch information
babsingh committed Feb 27, 2023
1 parent 9bf20a0 commit 2928f59
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ public void unlockAccess() {
isAccessible = true;
}

private static void execute(Continuation cont) {
private static void enter(Continuation cont) {
try {
cont.runnable.run();
} finally {
Expand Down
2 changes: 1 addition & 1 deletion runtime/oti/vmconstantpool.xml
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0 WITH Classpath-excepti
<staticmethodref class="jdk/internal/loader/NativeLibraries" name="load" signature="(Ljdk/internal/loader/NativeLibraries$NativeLibraryImpl;Ljava/lang/String;ZZ)Z" versions="19-"/>

<!-- Static method references needed to support VirtualThread/Continuation. -->
<staticmethodref class="jdk/internal/vm/Continuation" name="execute" signature="(Ljdk/internal/vm/Continuation;)V" versions="19-"/>
<staticmethodref class="jdk/internal/vm/Continuation" name="enter" signature="(Ljdk/internal/vm/Continuation;)V" versions="19-"/>
<!-- Security manager check -->
<staticfieldref class="java/lang/System" name="security" signature="Ljava/lang/SecurityManager;"/>

Expand Down
4 changes: 2 additions & 2 deletions runtime/vm/BytecodeInterpreter.hpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 1991, 2022 IBM Corp. and others
* Copyright (c) 1991, 2023 IBM Corp. and others
*
* This program and the accompanying materials are made available under
* the terms of the Eclipse Public License 2.0 which accompanies this
Expand Down Expand Up @@ -5231,7 +5231,7 @@ class INTERPRETER_CLASS
_vm->memoryManagerFunctions->preMountContinuation(_currentThread, continuationObject);

if (enterContinuation(_currentThread, continuationObject)) {
_sendMethod = J9VMJDKINTERNALVMCONTINUATION_EXECUTE_METHOD(_currentThread->javaVM);
_sendMethod = J9VMJDKINTERNALVMCONTINUATION_ENTER_METHOD(_currentThread->javaVM);
rc = GOTO_RUN_METHOD;
}

Expand Down

0 comments on commit 2928f59

Please sign in to comment.