Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(0.46) x86-64: Implement an enhancement for byte array and char array System.arraycopy #202

Conversation

a7ehuo
Copy link
Contributor

@a7ehuo a7ehuo commented May 27, 2024

This PR ports eclipse-omr/omr#7332 into v0.46.0 release.


Implement an enhancement for byte array and char array System.arraycopy on x86-64.

Also add JIT options that disable array copy enhancement:

disableArrayCopyEnhancementByteArray: Disable array copy enhancement for 8 bit primitive array
disableArrayCopyEnhancementCharArray: Disable array copy enhancement for 16 bit primitive array

a7ehuo and others added 3 commits May 27, 2024 12:23
The setup to run `rep movsd` is not efficient on copying smaller sizes.
The enhancement inlines copy size equal or less than 64 bytes without
using `rep movsd`.

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
The setup to run `rep movsb` is not efficient on copying smaller sizes.
The enhancement inlines copy size equal or less than 64 bytes without
using `rep movsb`.

Co-Authored-By: Henry Zongaro <zongaro@ca.ibm.com>
Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
`disableArrayCopyByteArrayInlineSmallSizeWithoutREPMOVS`
- Disable array copy enhancement for 8 bit primitive array

`disableArrayCopyCharArrayInlineSmallSizeWithoutREPMOVS`
- Disable array copy enhancement for 16 bit primitive array

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo
Copy link
Contributor Author

a7ehuo commented May 27, 2024

@0xdaryl @vijaysun-omr @hzongaro fyi

@0xdaryl 0xdaryl self-assigned this May 29, 2024
Copy link
Contributor

@0xdaryl 0xdaryl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge today. @pshipton FYI.

@0xdaryl 0xdaryl merged commit 4f15d6a into eclipse-openj9:v0.46.0-release May 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants