Skip to content

Changed public declaration of self() to protected #8080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
HassanIqbal715 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changed public declaration of self() to protected #8080

HassanIqbal715 wants to merge 1 commit into from

Conversation

@HassanIqbal715
Copy link

@HassanIqbal715 HassanIqbal715 commented Jan 6, 2026 •
edited
Loading

I found and changed public declarations of self() to protected in all (hopefully) the files found in ./compiler directory.

  • For the classes that already contained a protected section, I declared self() at the top of that section.
  • For the classes that did not contain protected section, I made one at the top of the class and declared self() there.

This pr is for the issue #5780

@HassanIqbal715
Copy link
Author

HassanIqbal715 commented Jan 6, 2026 •
edited
Loading

@hzongaro could you please review this?

@hzongaro hzongaro self-assigned this Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mstoodle mstoodle Awaiting requested review from mstoodle mstoodle is a code owner

@vijaysun-omr vijaysun-omr Awaiting requested review from vijaysun-omr vijaysun-omr is a code owner

@dsouzai dsouzai Awaiting requested review from dsouzai dsouzai is a code owner

@0xdaryl 0xdaryl Awaiting requested review from 0xdaryl 0xdaryl is a code owner

Assignees

@hzongaro hzongaro

Labels

comp:compiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HassanIqbal715 @hzongaro