Refactor ARM64HelperCallSnippet #8068
Conversation
There was a problem hiding this comment.
The logic and spirit of this PR generally looks good. Three additional things:
- Consider a commit/PR message more descriptive of what this PR is doing, something like:
Refactor
ARM64HelperCallSnippet::emitSnippetBody()to allow the helper call emission logic to be shared with downstream projects.
-
In the commit/PR titles, change ARM to ARM64.
-
Please fix the ClangFormat errors
| uint8_t *TR::ARM64HelperCallSnippet::emitSnippetBody() | ||
| { | ||
| uint8_t *cursor = cg()->getBinaryBufferCursor(); | ||
| uint8_t *TR::ARM64HelperCallSnippet::emitSnippetBodyHelper(uint8_t *cursor) |
There was a problem hiding this comment.
We often use the term Inner in these contexts when the guts of a function are refactored like this: emitSnippetBodyInner
Your term Helper in this context is a bit confusing in light of the fact this snippet is about emitting Helper calls. Unless there is a deeper connection here that I am missing.
matthewhall2
force-pushed
the
dispatchJ9Method_MH_aarch64
branch
from
619c9d0 to
5f95046
Compare
matthewhall2
changed the title
|
Thanks @0xdaryl , I've addressed your comments. I've also added a couple small changes for debug printing. See PR description for details. |
matthewhall2
force-pushed
the
dispatchJ9Method_MH_aarch64
branch
2 times, most recently
from
80a1fcf to
e0e7be9
Compare
|
Your commit message says:
But I don't see that in this PR. Is it missing, or do the messages need to be updated? |
Refactors ARM64HelperCallSnippet::emitSnippetBody so that the helper call emission logic can be used by downstream projects. Removes deprecated TR_Debug::print for ARM64HelperCallSnippet and replaces with newer TR::ARM64HelperCallSnippet::print - TR::ARM64HelperCallSnippet::printInner to be used by downstream projects Signed-off-by: Matthew Hall <matthew.hall3@outlook.com>
matthewhall2
force-pushed
the
dispatchJ9Method_MH_aarch64
branch
from
e0e7be9 to
29fbede
Compare
Just forgot to update the message after I took that change out |
2 participants
Refactors ARM64HelperCallSnippet::emitSnippetBody so that the helper call emission logic can be used by downstream projects.
Removes deprecated TR_Debug::print for ARM64HelperCallSnippet and replaces with newer TR::ARM64HelperCallSnippet::print
- TR::ARM64HelperCallSnippet::printInner to be used by downstream projects
must be merged before eclipse-openj9/openj9#23085. This should not require a coordinated merge.