WIP: Consolidate JIT log file name construction #8066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
0xdaryl
commented
Dec 3, 2025
0xdaryl
commented
- Add factory constructor for TR::Options
- Add proper allocator support to Loggers
- Introduce CompilerEnv message logger
- Redesign log filename builder
0xdaryl
requested review from
dsouzai,
mstoodle and
vijaysun-omr
as code owners
0xdaryl
force-pushed
the
logger.namebuilder
branch
from
d73173f to
792eadb
Compare
Contributor
Author
|
Jenkins build all |
0xdaryl
force-pushed
the
logger.namebuilder
branch
from
792eadb to
e16a51d
Compare
Contributor
Author
|
Jenkins build all |
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
Signed-off-by: Daryl Maier <maier@ca.ibm.com>
* Consolidate and simplify the construction of log file names by creating a builder that synthesizes a file name from a base name, an optional numerical suffix, and an optional suffix that can contain special format specifiers. The suffix is processed by the port library, if one exists. The format specifiers are those described in the documentation for 'omrstr_create_tokens()' in port/common/omrstr.c. * Remove now-obsolete FrontEnd name formatter and non-port library code for collecting the pid and current time * Rename some identifiers to match what their actual semantics are * Rename enable/disable compiler options for applying log file name suffixes to be more descriptive Signed-off-by: Daryl Maier <maier@ca.ibm.com>
0xdaryl
force-pushed
the
logger.namebuilder
branch
from
e16a51d to
9416f7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.