Fix and improve debug counters for failed call sites #7410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jdmpapin
commented
Jul 17, 2024
jdmpapin
commented
- Create debug counters correctly for removed call sites
- Specify the current compilation in failed call site debug counter names
This was passing callsite->_callNodeTreeTop while it was still null, which prevented the debug counter increment from being generated and even prevented a static debug counter increment. The treetop where the call occurs is tt, and in this case callsite is the result of searching for a dead call site that matches it. This tt is already used for the Unresolved_In_ECS case, and it's also the value that callsite->_callNodeTreeTop would take on just below if callsite hadn't been removed.
This way, if a particular failure reason is of interest, the debug counters will list all of the methods in which inlining failed for that reason.
|
Jenkins build all |
0xdaryl
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.