Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option useHigherMethodCounts Now Correctly Sets the scount #7372

Conversation

luke-li-2003
Copy link
Contributor

TR_UseHigherUserCounts now sets the intial scount to the value of initial count after the initial count has been set, to avoid the initial scount being set to -1

Measurements: when running acmeairee8 on OpenJ9 with
-Xjit:useHigherMethodCounts -Xaot:useHigherMethodCounts, there is a 2% throughput improvement with 2.3% start-up time increase

TR_UseHigherUserCounts now sets the intial scount to the value
of initial count after the initial count has been set, to avoid
the initial scount being set to -1

Measurements: when running acmeairee8 with
`-Xjit:useHigherMethodCounts -Xaot:useHigherMethodCounts`,
there is a 2% throughput improvement with 2.3% start-up
time increase

Signed-off-by: Luke Li <luke.li@ibm.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for supporting the project, and congratulations on your first contribution! A project committer will shortly review your contribution. In the mean time, if you haven't had a chance please skim over the contribution guidelines which all pull requests must adhere to. If the ECA pull request check fails, have a look at the instructions for signing the ECA in the legal considerations section.

If you run into any problems our community will be happy to assist you in any way we can. There are a number of recommended ways to interact with the community. We encourage you to ask questions, or drop by to say hello.

@dsouzai
Copy link
Contributor

dsouzai commented Jun 26, 2024

@mpirvu could you please review? If the change looks good to you I can run tests/merge.

@dsouzai dsouzai self-assigned this Jun 26, 2024
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsouzai
Copy link
Contributor

dsouzai commented Jun 27, 2024

Jenkins build all

@dsouzai dsouzai merged commit befee22 into eclipse-omr:master Jun 27, 2024
17 checks passed
@luke-li-2003 luke-li-2003 deleted the SetSCountWhenUsingUseHigherMethodCounts branch October 25, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants