Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error caused by unused variable in OSX #7316

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

ChungHsuanChen
Copy link
Contributor

Remove unused local variable in fvtest which will cause build error
In omrtimeTest.cpp
Non used variable
In si.cpp
Non used variable2

Changes

  • omrtimeTest.cpp, replace for loop with while loop as variable 'j' isn't used
  • si.cpp, remove l that not use as any purpose

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for supporting the project, and congratulations on your first contribution! A project committer will shortly review your contribution. In the mean time, if you haven't had a chance please skim over the contribution guidelines which all pull requests must adhere to. If the ECA pull request check fails, have a look at the instructions for signing the ECA in the legal considerations section.

If you run into any problems our community will be happy to assist you in any way we can. There are a number of recommended ways to interact with the community. We encourage you to ask questions, or drop by to say hello.

@babsingh
Copy link
Contributor

https://github.com/eclipse/omr/blob/master/CONTRIBUTING.md#commit-guidelines

The following commit message requirement is not met: The body should be wrapped at 72 characters, where reasonable.

Remove unused local variable in fvtest which will cause build error in OSX

Signed-off-by: ChungHsuanChen <chunghsuanchen7@gmail.com>
@knn-k
Copy link
Contributor

knn-k commented Apr 21, 2024

Jenkins build amac

Copy link
Contributor

@knn-k knn-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The test failure on x86-64 macOS is not caused by this PR. See #7181.

@babsingh babsingh merged commit 40107cb into eclipse-omr:master Apr 21, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants