Update differenceInAdditiveConstants as int64_t #7312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`differenceInAdditiveConstants` is expected to be a 64 bit integer. `examineOpCodesForInductionVariableUse` takes care of casting it into `int32_t` if it does not use aladd and the adjustment or the replacing node is not a 64-bit value. Fixes: eclipse-openj9/openj9#19220 Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
|
The x86-64 macOS failure is a known issue #7181 |
jdmpapin
approved these changes
Apr 16, 2024
|
Jenkins build all |
|
Everything has passed except for the known failure on mac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
differenceInAdditiveConstantsis expected to be a 64 bit integer.examineOpCodesForInductionVariableUsetakes care of casting it intoint32_tif it does not use aladd and the adjustment or the replacing node is not a 64-bit value.Fixes: eclipse-openj9/openj9#19220