Fixes documentation of disableGLU Xjit option #7306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xdaryl
reviewed
Apr 11, 2024
doc/compiler/CompilerOptions.md
Outdated
| @@ -135,7 +135,7 @@ options, etc). | |||
| | disableGRA | disable IL based global register allocator | | |||
| | disableInlining | disable IL inlining | | |||
| | disableLiveRegisterAnalysis | disable live register analysis | | |||
| | disableLoopUnroller | disable loop unroller | | |||
| | disableGLU | disable general loop unroller | | |||
There was a problem hiding this comment.
This table is in alphabetical order. Can you add the corrected name in the appropriate spot please?
There was a problem hiding this comment.
I moved it to the right place.
The documentation incorrectly lists "disableLoopUnroller" as the option to disable loop unroller. This option does not exist and will result in an unrecognized option error. The correct Xjit option name is "disableGLU" and the documentation has been updated to reflect this. Signed-off-by: jimmyk <jimmyk@ca.ibm.com>
0xdaryl
approved these changes
Apr 11, 2024
|
This is a documentation-only change. No CI is necessary. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation incorrectly lists "disableLoopUnroller" as the option to disable loop unroller. This option does not exist and will result in an unrecognized option error.
The correct Xjit option name is "disableGLU" and the documentation has been updated to reflect this.
The "disableGLU" option is defined here:
https://github.com/eclipse/omr/blob/0e07ad19c1f3a7ce41cebd121fde5756fa32fd0c/compiler/control/OMROptions.cpp#L343