Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose alloc cache size API #7263

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

amicic
Copy link
Contributor

@amicic amicic commented Feb 9, 2024

Expose remaining and refresh size APIs for ObjectAllocationInterface,
and implement it for TLHAllocationInterface.

While this values are functionally needed only internally within the
class, they will be used for stats reporting purposes outisde the class,
hence need to be public.

@amicic
Copy link
Contributor Author

amicic commented Feb 9, 2024

@dmitripivkine please, review

@amicic amicic force-pushed the expose_allocCacheSize_api branch 2 times, most recently from 427d904 to 1a93a9d Compare February 9, 2024 21:02
@dmitripivkine
Copy link
Contributor

@babsingh Would you please help to merge this?

@amicic
Copy link
Contributor Author

amicic commented Feb 13, 2024

@babsingh Would you please help to merge this?

@babsingh, a friendly reminder, in case you missed it

Copy link
Contributor

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder. Minor formatting nit: @return description should be on a new line. Otherwise, LGTM.

gc/base/ObjectAllocationInterface.hpp Outdated Show resolved Hide resolved
gc/base/ObjectAllocationInterface.hpp Outdated Show resolved Hide resolved
Expose remaining and refresh size APIs for ObjectAllocationInterface,
and implement it for TLHAllocationInterface.

While this values are functionally needed only internally within the
class, they will be used for stats reporting purposes outisde the class,
hence need to be public.

Signed-off-by: Aleksandar Micic <Aleksandar_Micic@ca.ibm.com>
@amicic
Copy link
Contributor Author

amicic commented Feb 13, 2024

Thanks for the reminder. Minor formatting nit: @return description should be on a new line. Otherwise, LGTM.

@babsingh have a look again

@babsingh
Copy link
Contributor

jenkins build all

@babsingh
Copy link
Contributor

jenkins build win

Copy link
Contributor

@babsingh babsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OSX PR build failed due to a known and unrelated issue: #7181.

@babsingh babsingh merged commit 823df4a into eclipse-omr:master Feb 13, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants