Off heap #7173
Open
Off heap #7173
+56
−165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinHu2016
requested review from
charliegracie,
youngar,
mstoodle and
0xdaryl
as code owners
LinHu2016
force-pushed
the
off-heap
branch
2 times, most recently
from
d5f7d96
to
faf2a82
Compare
|
Just a reminder to please use an imperative voice in all commit/PR titles describing what the commit/PR is about. |
LinHu2016
force-pushed
the
off-heap
branch
2 times, most recently
from
d4253b0
to
1507fd1
Compare
amicic
reviewed
Jul 10, 2024
| @@ -356,3 +357,9 @@ MM_GCExtensionsBase::usingSATBBarrier() | |||
| #endif /* defined(OMR_GC_REALTIME) */ | |||
| return false; | |||
| } | |||
|
|
|||
| bool | |||
| MM_GCExtensionsBase::isAddressWithinHeap(void *address) | |||
There was a problem hiding this comment.
check if we have something similar already
amicic
reviewed
Jul 10, 2024
| @@ -919,6 +919,7 @@ TraceAssert=Assert_MM_double_map_unreachable noEnv Overhead=1 Level=1 Assert="(f | |||
|
|
|||
| TraceEvent=Trc_ParallelGlobalGC_shouldCompactThisCycle Overhead=1 Level=1 Group=compact Template="Current page granularity fragmented ratio: %f Threshold: %f" | |||
|
|
|||
| //Trc_MM_double_map_Entry Obsolete | |||
amicic
reviewed
Jul 10, 2024
| @@ -1028,3 +1029,6 @@ TraceEvent=Trc_MM_MSSSS_flip_restore_tilt_after_percolate_current_status Overhea | |||
|
|
|||
| TraceEvent=Trc_MM_clearheap Overhead=1 Level=1 Group=gclogger Template="clearheap with free memory size: %zu, object size: %zu" | |||
| TraceEvent=Trc_MM_cleanUpSegmentsInAnonymousClassLoader_stats Overhead=1 Level=1 Group=gclogger Template="Anonymous classes: total: %zu, unloaded: %zu, searched ROM: %zu, found ROM fast: %zu, found ROM slow: %zu, not found ROM: %zu" | |||
|
|
|||
| //Redefine Trc_MM_double_map_Entry to add originalDataSize and adjustedDataSize | |||
amicic
reviewed
Jul 10, 2024
| @@ -1028,3 +1029,6 @@ TraceEvent=Trc_MM_MSSSS_flip_restore_tilt_after_percolate_current_status Overhea | |||
|
|
|||
| TraceEvent=Trc_MM_clearheap Overhead=1 Level=1 Group=gclogger Template="clearheap with free memory size: %zu, object size: %zu" | |||
| TraceEvent=Trc_MM_cleanUpSegmentsInAnonymousClassLoader_stats Overhead=1 Level=1 Group=gclogger Template="Anonymous classes: total: %zu, unloaded: %zu, searched ROM: %zu, found ROM fast: %zu, found ROM slow: %zu, not found ROM: %zu" | |||
|
|
|||
| //Redefine Trc_MM_double_map_Entry to add originalDataSize and adjustedDataSize | |||
| TraceEntry=Trc_MM_double_map_EntryNew Overhead=1 Level=3 Group=arraylet Template="MM_IndexableObjectAllocationModel::doubleMapArraylets. originalDataSize: %p, adjustedDataSize: %p, spine: %p, leafSize: %p leavesCount: %zu" | |||
There was a problem hiding this comment.
if this is redefining an existing one, then obsolete the old one
possible only if other (J9) changes goes together at the same time
otherwise (if OMR goes first), we can obsolete it only later
amicic
reviewed
Jul 10, 2024
| @@ -1513,8 +1523,10 @@ class MM_GCExtensionsBase : public MM_BaseVirtual { | |||
| , isArrayletDoubleMapRequested(false) | |||
| , isArrayletDoubleMapAvailable(false) | |||
| #endif /* defined(OMR_GC_DOUBLE_MAP_ARRAYLETS) */ | |||
| , isVirtualLargeObjectHeapRequested(false) | |||
| #if defined(OMR_GC_SPARSE_HEAP_ALLOCATION) | |||
| , isVirtualLargeObjectHeapRequested(true) | |||
There was a problem hiding this comment.
we will probably enable off-heap by default once all the code is delivered, but it should be done in downstream project during startup
Modifications required to complete the introduction of an optimized memory management scheme for large arrays in a region-based garbage collector. More specifically, this is a new heap scheme and large object organization (in-heap and off-heap), an enhanced method for allocating large objects (proxy objects), and an optimized technique of accessing large arrays during runtime (JIT optimizations). Related to: #14005 Signed-off-by: Jonathan Oommen jon.oommen@gmail.com
Signed-off-by: hulin <linhu@ca.ibm.com>
Signed-off-by: hulin <linhu@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications for Off-Heap Technology for Large Arrays in Region-Based Collectors
Carryforward from #6948