Separate compact reason for rasdump #7165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amicic
requested review from
charliegracie,
youngar,
mstoodle and
0xdaryl
as code owners
amicic
force-pushed
the
compact_rasdump_reason
branch
from
890802d
to
8fe3e32
Compare
|
@dmitripivkine please, review |
dmitripivkine
approved these changes
Nov 1, 2023
|
Please fix the typo in the commit comment |
|
@babsingh Would you please help to merge? |
The COMPACT_FORCED_GC reason was reused what indicated that an explicit command line option was specified confusing GCMV parser to incorrectly conclude there was an option while there was only a RAS dump. Now we use a dedicated reason with a different string issued by Verbose GC. Signed-off-by: Aleksandar Micic <Aleksandar_Micic@ca.ibm.com>
amicic
force-pushed
the
compact_rasdump_reason
branch
from
8fe3e32
to
82a191a
Compare
|
jenkins build all |
|
A known failure is seen in the riscv build, which is unrelated to this PR: #6905. |
babsingh
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The COMPACT_FORCED_GC reason was reused what indicated that an explicit
command line option was specified confusing GCMV parser to incorrectly
conclude there was an option while there was only a RAS dump.
Now we use a dedicated reason with a different string issued by Verbose
GC.
Signed-off-by: Aleksandar Micic Aleksandar_Micic@ca.ibm.com