Add TR::vnolz and TR::vnotz evaluators in z/codegen #7137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @r30shah for review. |
|
The failure in |
r30shah
suggested changes
Oct 11, 2023
| @@ -2337,6 +2325,76 @@ OMR::Z::TreeEvaluator::lbitpermuteEvaluator(TR::Node *node, TR::CodeGenerator *c | |||
| return TR::TreeEvaluator::bitpermuteEvaluator(node, cg); | |||
| } | |||
|
|
|||
| TR::Register* | |||
There was a problem hiding this comment.
Can we use inlineVectorUnaryOp ? It does most of the work this two function does.
r30shah
approved these changes
Oct 11, 2023
|
Jenkins build zlinux,zos |
|
@hzongaro given Daryl is away, can I request you to review and merge this change ? |
hzongaro
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces evaluators for the
TR::vnolzandTR::vnotzIL in the z/codegen. Support is only enabled for architectures with vector instruction support.