Z: Change CPU support flag setters to return void #7122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Spencer-Comin can you resolve the conflicts this is complaining about so that I can launch tests? |
Spencer-Comin
force-pushed
the
void-setters
branch
from
6462b5a
to
2069fda
Compare
|
Jenkins build zos,zlinux |
r30shah
approved these changes
Nov 30, 2023
|
@Spencer-Comin can you rebase your branch? Some how test is failing with missing newly added facility check for constrained and non constrained transaction memory check. |
Spencer-Comin
force-pushed
the
void-setters
branch
from
2069fda
to
b854a88
Compare
|
Jenkins build zos,zlinux |
1 similar comment
|
Jenkins build zos,zlinux |
hzongaro
reviewed
Nov 30, 2023
Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
Spencer-Comin
force-pushed
the
void-setters
branch
from
b854a88
to
1046181
Compare
|
Jenkins build zos,zlinux |
|
z/arch builds were successful and reviews approved. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
OMR::Z::CPU::setSupports*(bool value)methods return the inputvalue. The return value from these setters is not used anywhere, so there is no need to have a return value.