-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop special-casing unevaluated aconst in Power and ARM linkage #7101
Conversation
Instead, simply evaluate it like we do for other arguments. These were the only two places where a TR_RamMethodSequence relocation could be generated for a method other than the outermost method, which is not expected. All remaining uses of TR_RamMethodSequence are for compiledMethodSymbol, which always represents the outermost method.
@zl-wang : This seems reasonable to me. Are you ok with the Power changes? |
Is it worth only preventing special-casing for relocatable compilations? |
I didn't see any changes in the generated code outside of AOT, so I don't think we need to preserve the special case there OTOH, in AOT I did see some changes to the (PPC64) sequence generated for
I don't think we should be concerned about the use of the data snippet as it pertains to this PR. This change appears to affect only AOT, and it's highly unusual for non-null We might still want to try to improve the sequence generated for |
jenkins build aix,plinux,arm |
Jenkins build aix,plinux,arm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ...
Instead, simply evaluate it like we do for other arguments.
These were the only two places where a
TR_RamMethodSequence
relocation could be generated for a method other than the outermost method, which is not expected. All remaining uses ofTR_RamMethodSequence
are forcompiledMethodSymbol
, which always represents the outermost method.Fixes eclipse-openj9/openj9#17889