Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JitBuilder test optional #7097

Merged

Conversation

georgkrylov
Copy link
Contributor

@georgkrylov georgkrylov commented Aug 23, 2023

One of the tests (thunk), due to Jenkins not checking for Aarch64 and MacOSX was failing when built to run on all platforms. This commit moves this sample to the extended tests section.

This Pull Request addresses this comment , and acts as a temporary solution to #7096 , although additional discussion is pending.

@mstoodle , how does this look for a fix?

One of the tests (thunk), due to Jenkins not checking for Aarch and
MacOSX was failing when built to run on all platforms. This commit moves
this sample to optional tests.

Signed-off-by: Georgiy Krylov <georgiy.krylov@unb.ca>
Copy link
Contributor

@mstoodle mstoodle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though i'll do another round of tests for completeness

@mstoodle
Copy link
Contributor

jenkins build all

@mstoodle
Copy link
Contributor

mstoodle commented Aug 23, 2023

I did a little investigation: apparently JitBuilder doesn't explicitly create method symbols with TR_System linkage, so at least on Mac AArch64 (maybe everywhere?) it defaults to TR_Private. I made a local change to force that to TR_System, but then ran into the more serious problem that TR::ARM64SystemLinkage::buildIndirectDispatch() is TR_UNIMPLEMENTED. So I think we'll have to live with this test in the extended list for the time being (as this pull request does).

I'm still not quite sure what's going on with that Windows build, but looks like our Windows build machine may be a bit flakey. I'll try restarting it (again).

@mstoodle
Copy link
Contributor

mstoodle commented Aug 23, 2023

ok, windows build seems flakey and even though it failed building the jitbuilder library (that's job "32"), I don't believe it's due to this change because 1) this PR doesn't have any affect on the building of the library, and 2) all the jitbuilder testing ran just fine (on a different machine) yesterday after merging #7091. There was a PR failure yesterday on Windows for that earlier PR as well at one point. I'm just going to merge. Thanks for your contribution and patience, @georgkrylov .

Here's the sum total of the error reported in the PR build:

[2023-08-23T14:51:03.730Z] Cannot contact win2019x64-openj9-2: hudson.remoting.RequestAbortedException: java.io.IOException: Unexpected termination of the channel
[2023-08-23T14:52:24.961Z]     32>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(423,5): error MSB6006: "CL.exe" exited with code 4. [C:\omr\workspace\PullRequest-win_x86-64\Build\build\jitbuilder\jitbuilder.vcxproj]
[2023-08-23T14:52:24.961Z]     32>Done Building Project "C:\omr\workspace\PullRequest-win_x86-64\Build\build\jitbuilder\jitbuilder.vcxproj" (default targets) -- FAILED.
[2023-08-23T14:52:24.961Z]     30>Done Building Project "C:\omr\workspace\PullRequest-win_x86-64\Build\build\jitbuilder\release\conditionals.vcxproj" (default targets) -- FAILED.
[2023-08-23T14:52:24.961Z]      1>Done Building Project "C:\omr\workspace\PullRequest-win_x86-64\Build\build\ALL_BUILD.vcxproj" (default targets) -- FAILED.
[2023-08-23T14:52:24.961Z] 
[2023-08-23T14:52:24.961Z] Build FAILED.

Windows error code 4 is "too many open files"

@mstoodle mstoodle merged commit 51ac424 into eclipse-omr:master Aug 23, 2023
5 checks passed
@georgkrylov
Copy link
Contributor Author

Thank you @mstoodle for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants