Do not resize Copy Scan Cache pool after overflow #7060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the logic where we try to resize Copy Scan Cache pool at the end of Scavenge cycle, after we overflowed it and fullfilled it from Java Heap. This overflow is extremly unlikely, and if does occur it means native memory is depleted and some other problems will soon occur anyway, so trying hard to preemtpively take that memory for our pool is probably just futile. On the other side, currently we will try to resize at the end of Scavenge, but assert since the increment was previously set to 0, when we artifically set the limit of this pool (with an fvt option). We already have means of preventing further pool growth during GC (from initial growth) from native heap beyond the limit (by recognizing fvt option was set), and we don't even need to set increment to 0. Signed-off-by: Aleksandar Micic <Aleksandar_Micic@ca.ibm.com>
|
@dmitripivkine please, take a look |
dmitripivkine
approved these changes
Jul 11, 2023
|
@babsingh Would you please help to merge this? |
|
jenkins build all |
babsingh
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
zOS PR build will fail since all nodes of label ‘compile:zos’ are offline.
Merging: these are platform independent changes; zOS PR build is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the logic where we try to resize Copy Scan Cache pool at the end of Scavenge cycle, after we overflowed it and fullfilled it from Java Heap.
This overflow is extremly unlikely, and if does occur it means native memory is depleted and some other problems will soon occur anyway, so trying hard to preemtpively take that memory for our pool is probably just futile.
On the other side, currently we will try to resize at the end of Scavenge, but assert since the increment was previously set to 0, when we artifically set the limit of this pool (with an fvt option). We already have means of preventing further pool growth during GC (from initial growth) from native heap beyond the limit (by recognizing fvt option was set), and we don't even need to set increment to 0.