Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement for calculation of heuristic multipliers #7025

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

dmitripivkine
Copy link
Contributor

Use floats to calculate more accurate result.

Fixes eclipse-openj9/openj9#17534

@dmitripivkine
Copy link
Contributor Author

@amicic Would you please review?

@dmitripivkine
Copy link
Contributor Author

@babsingh Would you please help with this item?

@babsingh
Copy link
Contributor

babsingh commented Jun 6, 2023

https://dev.azure.com/eclipse-omr/ea4519db-b27e-4d19-a971-f01491f803e3/_apis/build/builds/7648/logs/36

There are errors in the Windows PR build related to possible loss of data:

2023-06-06T20:34:51.6939462Z D:\a\1\s\gc\base\MemorySubSpaceUniSpace.cpp(709,29): error C2220: the following warning is treated as an error [D:\a\1\s\build\gc\omrgc.vcxproj]
2023-06-06T20:34:51.6944362Z D:\a\1\s\gc\base\MemorySubSpaceUniSpace.cpp(709,29): warning C4244: 'initializing': conversion from 'double' to 'float', possible loss of data [D:\a\1\s\build\gc\omrgc.vcxproj]
2023-06-06T20:34:51.6950635Z D:\a\1\s\gc\base\MemorySubSpaceUniSpace.cpp(733,29): warning C4244: 'initializing': conversion from 'double' to 'float', possible loss of data [D:\a\1\s\build\gc\omrgc.vcxproj]

@amicic
Copy link
Contributor

amicic commented Jun 6, 2023

https://dev.azure.com/eclipse-omr/ea4519db-b27e-4d19-a971-f01491f803e3/_apis/build/builds/7648/logs/36

There are errors in the Windows PR build related to possible loss of data:

2023-06-06T20:34:51.6939462Z D:\a\1\s\gc\base\MemorySubSpaceUniSpace.cpp(709,29): error C2220: the following warning is treated as an error [D:\a\1\s\build\gc\omrgc.vcxproj]
2023-06-06T20:34:51.6944362Z D:\a\1\s\gc\base\MemorySubSpaceUniSpace.cpp(709,29): warning C4244: 'initializing': conversion from 'double' to 'float', possible loss of data [D:\a\1\s\build\gc\omrgc.vcxproj]
2023-06-06T20:34:51.6950635Z D:\a\1\s\gc\base\MemorySubSpaceUniSpace.cpp(733,29): warning C4244: 'initializing': conversion from 'double' to 'float', possible loss of data [D:\a\1\s\build\gc\omrgc.vcxproj]

I'm guessing 2.0 is a double, should use 2.0f (or cast)

Use floats to calculate more accurate result.

Fixes eclipse-openj9/openj9#17534

Signed-off-by: Dmitri Pivkine <Dmitri_Pivkine@ca.ibm.com>
@babsingh
Copy link
Contributor

babsingh commented Jun 7, 2023

jenkins build all

@babsingh babsingh merged commit ae7bf1a into eclipse-omr:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JDK 8/11/17] Unhandled exception Type=Floating point error, when using option '-Xmint0.0 -Xmaxt0.01'
3 participants