Recreate simplified select node #7007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build all |
|
@0xdaryl ping as a reminder about this one. |
-when a select of two 0/1 constants is simplified to the reverse of its condition node, in the case where the select has a reference count > 1 and the condition first child has a reference count of only 1, the second reference to the select node will be simplified incorrectly to a twice-reversed condition (please see issue eclipse-omr#7006 for details). -recreates the select node in order to preserve the simplification done to it for future references, reducing repeated simplification of a previously commoned node and preventing the error in the case described above Closes: eclipse-omr#7006
kevindean12
force-pushed
the
select-simplifier-refcounts
branch
from
f3ffed2
to
ead5925
Compare
0xdaryl
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a select of two 0/1 constants is simplified to the reverse of its condition node, in the case where the select has a reference count > 1 and the condition first child has a reference count of only 1, the second reference to the select node will be simplified incorrectly to a twice-reversed condition (please see issue #7006 for details). Recreates the select node in order to preserve the simplification done to it for future references, reducing repeated simplification of a previously commoned node and preventing the error in the case described above.