Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various misspellings of "address" #6993

Merged
merged 1 commit into from
May 24, 2023
Merged

Fix various misspellings of "address" #6993

merged 1 commit into from
May 24, 2023

Conversation

dylanjtuttle
Copy link
Contributor

Fix a few occurrences of "address" being misspelled as "adress"

Closes: #6979

@0xdaryl
Copy link
Contributor

0xdaryl commented May 17, 2023

Jenkins build all

@0xdaryl 0xdaryl self-assigned this May 17, 2023
@0xdaryl
Copy link
Contributor

0xdaryl commented May 18, 2023

@hzongaro : I think you should have commit rights now. Care to test them on this PR?

@hzongaro
Copy link
Contributor

Jenkins build win

hzongaro
hzongaro reviewed May 23, 2023
View reviewed changes
Copy link
Contributor

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dylan @dylanjtuttle, thanks for fixing these typos. I just tripped across one more in compiler/il/OMRStaticSymbol.hpp. May I ask you to fix that one while you're at it?

@hzongaro hzongaro self-assigned this May 23, 2023
@dylanjtuttle
Copy link
Contributor Author

@hzongaro Of course! I did notice previously that there are also a few more typos in jitbuilder/lljb/include/lljb/Compiler.hpp and port/ztpf/omrosdump_helpers.c. I didn't bother to change them at the time because they were in comments (which was a bit of a silly reason in hindsight), but they also aren't in the compiler. Should I just leave those ones be?

dylanjtuttle added a commit to dylanjtuttle/omr that referenced this pull request May 23, 2023
@dylanjtuttle
Fix another Address misspelling
bca8e68 
Fix a misspelling of address in a comment

Issue: eclipse-omr#6993
Signed-off-by: Dylan Tuttle <jdylantuttle@gmail.com>
@hzongaro
Copy link
Contributor

I did notice previously that there are also a few more typos in jitbuilder/lljb/include/lljb/Compiler.hpp and port/ztpf/omrosdump_helpers.c

I would suggest that, as you've noticed them and there's no harm in fixing them, you should go ahead and make those corrections as well. Thanks!

dylanjtuttle added a commit to dylanjtuttle/omr that referenced this pull request May 23, 2023
@dylanjtuttle
Fix the last two "address" misspellings
6dc63e4 
Fix two more misspellings of "address" in JITbuilder and port

Issue: eclipse-omr#6993
Signed-off-by: Dylan Tuttle <jdylantuttle@gmail.com>
@dylanjtuttle
Copy link
Contributor Author

Done, squashing my commits now

@dylanjtuttle
Fix various misspellings of "Address"
644cd1f 
Fix a few occurrences of "address" being misspelled as "adress"

Closes: eclipse-omr#6979
Signed-off-by: Dylan Tuttle <jdylantuttle@gmail.com>
hzongaro
hzongaro approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hzongaro
Copy link
Contributor

Jenkins build all

@hzongaro
Copy link
Contributor

Risc-v failure is unrelated to this change. Merging.

@hzongaro hzongaro merged commit 8091ced into eclipse-omr:master May 24, 2023
@dylanjtuttle dylanjtuttle deleted the fixMisspellingsOfAddress branch May 24, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzongaro hzongaro hzongaro approved these changes

@fjeremic fjeremic Awaiting requested review from fjeremic

@0xdaryl 0xdaryl Awaiting requested review from 0xdaryl 0xdaryl is a code owner

@knn-k knn-k Awaiting requested review from knn-k knn-k is a code owner

@charliegracie charliegracie Awaiting requested review from charliegracie

@mstoodle mstoodle Awaiting requested review from mstoodle mstoodle is a code owner

@vijaysun-omr vijaysun-omr Awaiting requested review from vijaysun-omr

@Leonardo2718 Leonardo2718 Awaiting requested review from Leonardo2718

@youngar youngar Awaiting requested review from youngar

@babsingh babsingh Awaiting requested review from babsingh babsingh is a code owner

Assignees

@hzongaro hzongaro

Labels
arch:aarch64 arch:z comp:compiler comp:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix various misspellings of "address"
3 participants
@dylanjtuttle @0xdaryl @hzongaro