Fix 0 getContractionSize() in MemorySubSpaceGenerational #5543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-hall
requested review from
charliegracie,
rwy7 and
youngar
as code owners
|
@amicic : please review |
|
Append your commit/PR comment why you are doing this (currently, compaction to aid contraction is effectively disabled). |
jason-hall
force-pushed
the
getContractionSize
branch
from
7dab858
to
e167a76
Compare
amicic
approved these changes
Nov 12, 2020
|
The change looks good, but again, please give a better high level description (in both commit message and PR comment) what this change does. For example: in Gencon GC policy, it allows (or fixes a bug that prevents) a compaction to aid Tenure contraction to occur. Just listing specific code changes that you've done isn't that helpful. |
jason-hall
force-pushed
the
getContractionSize
branch
from
e167a76
to
cbe7db7
Compare
amicic
approved these changes
Dec 1, 2020
Fixes a bug in Gencon where an incorrectly returned 0 contraction size prevents additional compaction to aid contraction from occuring. The generational memory subspace was returining its own unused field rather than the correct contraction size of the actual sub space. Signed-off-by: Jason Hall <jasonhal@ca.ibm.com>
jason-hall
force-pushed
the
getContractionSize
branch
from
cbe7db7
to
c6f0224
Compare
|
Updated copyrights only |
|
@fjeremic Can we merge this? |
|
@genie-omr build all |
fjeremic
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in Gencon where an incorrectly returned 0 contraction size
prevents additional compaction to aid contraction from occuring. The
generational memory subspace was returining its own unused field rather
than the correct contraction size of the actual sub space.
Signed-off-by: Jason Hall jasonhal@ca.ibm.com