Remove deprecated code from StoreSinking #5365
Conversation
|
@genie-omr build all |
| @@ -619,19 +613,6 @@ int32_t TR_SinkStores::performStoreSinking() | |||
| _placementsForEdgesToBlock = (TR_EdgeStorePlacementList **) trMemory()->allocateStackMemory(arraySize); | |||
| memset(_placementsForEdgesToBlock, 0, arraySize); | |||
|
|
|||
| // some extra meta data is needed if stores with indirect loads are going to be sunk | |||
| if (sinkStoresWithIndirectLoads()) | |||
There was a problem hiding this comment.
Note to reviewers: this function always returned false, hence the code it guards was removed.
| // A single store that is being replicated to a side exit may have 0 or more nodes replaced with anchored nodes for different reasons | ||
| // insertAnchoredNodes will take care of all possible node replacements so only a single recursive walk of a store is required | ||
| uint32_t | ||
| TR_SinkStores::insertAnchoredNodes(TR_MovableStore *store, |
There was a problem hiding this comment.
Note to reviewers: this function is unreachable (except via a recursive call). It is removed as well as the data structures that only it used. Most of the other deletions in this PR are derived from this removal.
0xdaryl
force-pushed
the
anchorednodes
branch
from
ec90f89
to
367749b
Compare
The previous cleanup deprecated store sinking code in eclipse-omr#3893 left some unreachable remnants behind. Remove them now. Signed-off-by: Daryl Maier <maier@ca.ibm.com>
0xdaryl
force-pushed
the
anchorednodes
branch
from
367749b
to
d5e632a
Compare
|
@vijaysun-omr : you asked me privately to add a comment to the code mentioning that handling of indirects was removed in a previous PR. I didn't find a convenient place to mention that in the code, so instead I amended the commit message itself to reference PR #3893 that led to these vestigial elements being cleaned up here. |
|
Just a reminder ping @vijaysun-omr . No urgency on this though. |
|
Thanks, I will merge once tests pass |
|
@genie-omr build all |
1 similar comment
|
@genie-omr build all |
|
@genie-omr build zos |
|
This change is not platform dependent as such and the zOS build machine issues have been persisting for a few days now. So I am merging this change (rather than wait for the zOS issues to be resolved). |
A previous cleanup of this code left some unreachable remnants behind. Remove them now.
Signed-off-by: Daryl Maier maier@ca.ibm.com